From f3f671aa90ec9943a1af2d27126c265f76a99772 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Tue, 29 Aug 2017 09:36:33 -0700 Subject: [PATCH] Align first nav item in settings Summary: This removes the redundant "Account" label and item, and just keeps the page better aligned. Test Plan: Review personal settings Reviewers: epriestley Reviewed By: epriestley Spies: Korvin Differential Revision: https://secure.phabricator.com/D18489 --- .../controller/PhabricatorSettingsMainController.php | 5 ++++- .../panelgroup/PhabricatorSettingsAccountPanelGroup.php | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/applications/settings/controller/PhabricatorSettingsMainController.php b/src/applications/settings/controller/PhabricatorSettingsMainController.php index 1e4d4a0b70..9dc84a9bd0 100644 --- a/src/applications/settings/controller/PhabricatorSettingsMainController.php +++ b/src/applications/settings/controller/PhabricatorSettingsMainController.php @@ -205,7 +205,10 @@ final class PhabricatorSettingsMainController if ($panel->getPanelGroupKey() != $group_key) { $group_key = $panel->getPanelGroupKey(); $group = $panel->getPanelGroup(); - $nav->addLabel($group->getPanelGroupName()); + $panel_name = $group->getPanelGroupName(); + if ($panel_name) { + $nav->addLabel($panel_name); + } } $nav->addFilter($panel->getPanelKey(), $panel->getPanelName()); diff --git a/src/applications/settings/panelgroup/PhabricatorSettingsAccountPanelGroup.php b/src/applications/settings/panelgroup/PhabricatorSettingsAccountPanelGroup.php index f81d5d487a..826118b881 100644 --- a/src/applications/settings/panelgroup/PhabricatorSettingsAccountPanelGroup.php +++ b/src/applications/settings/panelgroup/PhabricatorSettingsAccountPanelGroup.php @@ -6,7 +6,7 @@ final class PhabricatorSettingsAccountPanelGroup const PANELGROUPKEY = 'account'; public function getPanelGroupName() { - return pht('Account'); + return null; } protected function getPanelGroupOrder() {