revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 16:22:43 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exception when DarkConsole is enabled

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

This is not visible in the web user interface, only in the PHP error log.

Closes T15344

Test Plan: Applied this change, on top of D25165 locally applied, and no stacktrace is printed anymore in the PHP error log.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15344

Differential Revision: https://we.phorge.it/D25188
This commit is contained in:
Andre Klapper 2023-05-05 14:50:51 +02:00
parent b0044bad62
commit f4d28119e8
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/applications/console/controller/DarkConsoleController.php
View file

@ -25,8 +25,9 @@ final class DarkConsoleController extends PhabricatorController {
return $response; return $response;
} }
// This should be '0' when closed and '1' when opened
$visible = $request->getStr('visible'); $visible = $request->getStr('visible');
if (strlen($visible)) { if (phutil_nonempty_string($visible)) {
$this->writeDarkConsoleSetting( $this->writeDarkConsoleSetting(
PhabricatorDarkConsoleVisibleSetting::SETTINGKEY, PhabricatorDarkConsoleVisibleSetting::SETTINGKEY,
(int)$visible); (int)$visible);