1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-09 16:32:39 +01:00

The feed "created this task" should be the first one

Summary:
Create a Maniphest task, Resolved, High priority.

Before this change, this was the feed in the object page:

- a.lincoln closed this task as Resolved.
- a.lincoln triaged this task as High priority.
- a.lincoln __created this task__.

After this change, this is the feed:

- a.lincoln __created this task__.
- a.lincoln closed this task as Resolved.
- a.lincoln triaged this task as High priority.

This also improves the situation in the /feed/ page. So you see the creation now.

Ref T15816

Test Plan:
Create an object in any mentioned application below, setting all fields.

Then, check the history of the object itself. Check also the /feed/ page.
Check that the creation action is now listed first.

This change improves the situation in:

- Maniphest
- Phriction

This change has no impact on these that seem already OK:

- Calendar
- Dashboard
- Dashboard Panel
- Diffusion
- Macro
- Paste
- Ponder
- Project
- Pholio

This change has no impact on these that seem still in the wrong order:

- Differential

The above situation in Differential is noted, but it's unrelated,
since it has a different legacy structure and it deserves more triaging.

Reviewers: O1 Blessed Committers, aklapper

Reviewed By: O1 Blessed Committers, aklapper

Subscribers: aklapper, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15816

Differential Revision: https://we.phorge.it/D25626
This commit is contained in:
Valerio Bozzolan 2024-05-18 10:05:18 +02:00
parent a6499aee0e
commit f4d9d6920b

View file

@ -27,4 +27,13 @@ final class PhabricatorCoreCreateTransaction
return $editor->getCreateObjectTitleForFeed($author, $object);
}
public function getActionStrength() {
// The creation feed is supposed to be "more important" than other things.
// So a Task is first created and then closed, and not vice-versa.
// The default null was causing weirdnesses in Maniphest and Phriction.
// See ManiphestTaskTitleTransaction#getActionStrength()
// See PhrictionDocumentTitleTransaction#getActionStrength()
return 140;
}
}