Use a label for default home menu

Summary: Ref T12174, I think this feels slightly nicer having "Applications"

Test Plan: Review home changes

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T12174

Differential Revision: https://secure.phabricator.com/D17287

src/applications/home/constants/PhabricatorHomeConstants.php

@@ -6,5 +6,6 @@ final class PhabricatorHomeConstants
   const ITEM_HOME = 'home.dashboard';
   const ITEM_LAUNCHER = 'home.launcher';
   const ITEM_MANAGE = 'home.manage.menu';
+  const ITEM_APPS_LABEL = 'home.apps.label';
 
 }

src/applications/home/engine/PhabricatorHomeProfileMenuEngine.php

@@ -26,8 +26,12 @@ final class PhabricatorHomeProfileMenuEngine
     // Default Home Dashboard
     $items[] = $this->newItem()
       ->setBuiltinKey(PhabricatorHomeConstants::ITEM_HOME)
-      ->setMenuItemKey(
-        PhabricatorHomeProfileMenuItem::MENUITEMKEY);
+      ->setMenuItemKey(PhabricatorHomeProfileMenuItem::MENUITEMKEY);
+
+    $items[] = $this->newItem()
+      ->setBuiltinKey(PhabricatorHomeConstants::ITEM_APPS_LABEL)
+      ->setMenuItemKey(PhabricatorLabelProfileMenuItem::MENUITEMKEY)
+      ->setMenuItemProperties(array('name' => pht('Applications')));
 
     foreach ($applications as $application) {
       if (!$application->isPinnedByDefault($viewer)) {
@@ -48,8 +52,7 @@ final class PhabricatorHomeProfileMenuEngine
     // Hotlink to More Applications Launcher...
     $items[] = $this->newItem()
       ->setBuiltinKey(PhabricatorHomeConstants::ITEM_LAUNCHER)
-      ->setMenuItemKey(
-        PhabricatorHomeLauncherProfileMenuItem::MENUITEMKEY);
+      ->setMenuItemKey(PhabricatorHomeLauncherProfileMenuItem::MENUITEMKEY);
 
     $items[] = $this->newManageItem();