1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 12:00:55 +01:00

Make loading large changesets slightly easier

Summary: Fixes T3942, turns the load links into buttons.

Test Plan: Set my limit to 1, test page.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T3942

Differential Revision: https://secure.phabricator.com/D10775
This commit is contained in:
Chad Little 2014-11-03 09:31:23 -08:00
parent d1d3b32213
commit f5235f7e09
2 changed files with 5 additions and 3 deletions

View file

@ -145,12 +145,13 @@ final class DifferentialRevisionViewController extends DifferentialController {
$warning->appendChild(hsprintf( $warning->appendChild(hsprintf(
'%s <strong>%s</strong>', '%s <strong>%s</strong>',
pht( pht(
'This diff is very large and affects %s files. Load each file '. 'This diff is very large and affects %s files. '.
'individually.', 'You may load each file individually or ',
new PhutilNumber($count)), new PhutilNumber($count)),
phutil_tag( phutil_tag(
'a', 'a',
array( array(
'class' => 'button grey',
'href' => $request_uri 'href' => $request_uri
->alter('large', 'true') ->alter('large', 'true')
->setFragment('toc'), ->setFragment('toc'),

View file

@ -175,6 +175,7 @@ final class DifferentialChangesetListView extends AphrontView {
$load = javelin_tag( $load = javelin_tag(
'a', 'a',
array( array(
'class' => 'button grey',
'href' => '#'.$uniq_id, 'href' => '#'.$uniq_id,
'sigil' => 'differential-load', 'sigil' => 'differential-load',
'meta' => array( 'meta' => array(
@ -183,7 +184,7 @@ final class DifferentialChangesetListView extends AphrontView {
), ),
'mustcapture' => true, 'mustcapture' => true,
), ),
pht('Load')); pht('Load File'));
} }
$detail->appendChild( $detail->appendChild(
phutil_tag( phutil_tag(