Remove Differential "View Policy" field

Summary: Ref T11114. Obsoleted by EditEngine.

Test Plan: Edited the view policy of a revision.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17082

src/__phutil_library_map__.php

@@ -582,7 +582,6 @@ phutil_register_library_map(array(
     'DifferentialUnitStatus' => 'applications/differential/constants/DifferentialUnitStatus.php',
     'DifferentialUnitTestResult' => 'applications/differential/constants/DifferentialUnitTestResult.php',
     'DifferentialUpdateRevisionConduitAPIMethod' => 'applications/differential/conduit/DifferentialUpdateRevisionConduitAPIMethod.php',
-    'DifferentialViewPolicyField' => 'applications/differential/customfield/DifferentialViewPolicyField.php',
     'DiffusionAuditorDatasource' => 'applications/diffusion/typeahead/DiffusionAuditorDatasource.php',
     'DiffusionAuditorFunctionDatasource' => 'applications/diffusion/typeahead/DiffusionAuditorFunctionDatasource.php',
     'DiffusionAuditorsAddAuditorsHeraldAction' => 'applications/diffusion/herald/DiffusionAuditorsAddAuditorsHeraldAction.php',
@@ -5247,7 +5246,6 @@ phutil_register_library_map(array(
     'DifferentialUnitStatus' => 'Phobject',
     'DifferentialUnitTestResult' => 'Phobject',
     'DifferentialUpdateRevisionConduitAPIMethod' => 'DifferentialConduitAPIMethod',
-    'DifferentialViewPolicyField' => 'DifferentialCoreCustomField',
     'DiffusionAuditorDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
     'DiffusionAuditorFunctionDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
     'DiffusionAuditorsAddAuditorsHeraldAction' => 'DiffusionAuditorsHeraldAction',

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

@@ -31,7 +31,6 @@ final class PhabricatorDifferentialConfigOptions
       new DifferentialReviewersField(),
       new DifferentialProjectReviewersField(),
       new DifferentialRepositoryField(),
-      new DifferentialViewPolicyField(),
 
       new DifferentialManiphestTasksField(),
       new DifferentialCommitsField(),

src/applications/differential/customfield/DifferentialViewPolicyField.php

@@ -1,50 +0,0 @@
-<?php
-
-final class DifferentialViewPolicyField
-  extends DifferentialCoreCustomField {
-
-  public function getFieldKey() {
-    return 'differential:view-policy';
-  }
-
-  public function getFieldName() {
-    return pht('View Policy');
-  }
-
-  public function getFieldDescription() {
-    return pht('Controls visibility.');
-  }
-
-  protected function readValueFromRevision(
-    DifferentialRevision $revision) {
-    return $revision->getViewPolicy();
-  }
-
-  public function readValueFromRequest(AphrontRequest $request) {
-    $this->setValue($request->getStr($this->getFieldKey()));
-  }
-
-  public function renderEditControl(array $handles) {
-    $viewer = $this->getViewer();
-    $revision = $this->getObject();
-
-    $policies = id(new PhabricatorPolicyQuery())
-      ->setViewer($viewer)
-      ->setObject($revision)
-      ->execute();
-
-    return id(new AphrontFormPolicyControl())
-      ->setUser($viewer)
-      ->setCapability(PhabricatorPolicyCapability::CAN_VIEW)
-      ->setPolicyObject($revision)
-      ->setPolicies($policies)
-      ->setName($this->getFieldKey())
-      ->setValue($this->getValue())
-      ->setError($this->getFieldError());
-  }
-
-  public function getApplicationTransactionType() {
-    return PhabricatorTransactions::TYPE_VIEW_POLICY;
-  }
-
-}