Update Notifications for handleRequest

Summary: Updates Notifcations for handleRequest

Test Plan: Test as much as I could, mark all, view, lists.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8628

Differential Revision: https://secure.phabricator.com/D13767

src/applications/notification/controller/PhabricatorNotificationClearController.php

@@ -3,10 +3,9 @@
 final class PhabricatorNotificationClearController
   extends PhabricatorNotificationController {
 
-  public function processRequest() {
+  public function handleRequest(AphrontRequest $request) {
-    $request = $this->getRequest();
+    $viewer = $request->getViewer();
     $chrono_key = $request->getStr('chronoKey');
-    $user = $request->getUser();
 
     if ($request->isDialogFormPost()) {
       $table = new PhabricatorFeedStoryNotification();
@@ -16,7 +15,7 @@ final class PhabricatorNotificationClearController
         'UPDATE %T SET hasViewed = 1 '.
         'WHERE userPHID = %s AND hasViewed = 0 and chronologicalKey <= %s',
         $table->getTableName(),
-        $user->getPHID(),
+        $viewer->getPHID(),
         $chrono_key);
 
       return id(new AphrontReloadResponse())
@@ -24,7 +23,7 @@ final class PhabricatorNotificationClearController
     }
 
     $dialog = new AphrontDialogView();
-    $dialog->setUser($user);
+    $dialog->setUser($viewer);
     $dialog->addCancelButton('/notification/');
     if ($chrono_key) {
       $dialog->setTitle(pht('Really mark all notifications as read?'));

src/applications/notification/controller/PhabricatorNotificationIndividualController.php

@@ -3,9 +3,8 @@
 final class PhabricatorNotificationIndividualController
   extends PhabricatorNotificationController {
 
-  public function processRequest() {
+  public function handleRequest(AphrontRequest $request) {
-    $request = $this->getRequest();
+    $viewer = $request->getViewer();
-    $viewer = $request->getUser();
 
     $stories = id(new PhabricatorNotificationQuery())
       ->setViewer($viewer)

src/applications/notification/controller/PhabricatorNotificationListController.php

@@ -3,15 +3,11 @@
 final class PhabricatorNotificationListController
   extends PhabricatorNotificationController {
 
-  private $queryKey;
+  public function handleRequest(AphrontRequest $request) {
+    $querykey = $request->getURIData('queryKey');
 
-  public function willProcessRequest(array $data) {
-    $this->queryKey = idx($data, 'queryKey');
-  }
-
-  public function processRequest() {
     $controller = id(new PhabricatorApplicationSearchController())
-      ->setQueryKey($this->queryKey)
+      ->setQueryKey($querykey)
       ->setSearchEngine(new PhabricatorNotificationSearchEngine())
       ->setNavigation($this->buildSideNavView());
 
@@ -19,13 +15,13 @@ final class PhabricatorNotificationListController
   }
 
   public function buildSideNavView() {
-    $user = $this->getRequest()->getUser();
+    $viewer = $this->getViewer();
 
     $nav = new AphrontSideNavFilterView();
     $nav->setBaseURI(new PhutilURI($this->getApplicationURI()));
 
     id(new PhabricatorNotificationSearchEngine())
-      ->setViewer($user)
+      ->setViewer($viewer)
       ->addNavigationItems($nav->getMenu());
     $nav->selectFilter(null);
 

src/applications/notification/controller/PhabricatorNotificationPanelController.php

@@ -3,14 +3,12 @@
 final class PhabricatorNotificationPanelController
   extends PhabricatorNotificationController {
 
-  public function processRequest() {
+  public function handleRequest(AphrontRequest $request) {
-
+    $viewer = $request->getViewer();
-    $request = $this->getRequest();
-    $user = $request->getUser();
 
     $query = id(new PhabricatorNotificationQuery())
-      ->setViewer($user)
+      ->setViewer($viewer)
-      ->withUserPHIDs(array($user->getPHID()))
+      ->withUserPHIDs(array($viewer->getPHID()))
       ->setLimit(15);
 
     $stories = $query->execute();
@@ -81,7 +79,7 @@ final class PhabricatorNotificationPanelController
       $connection_ui);
 
     $unread_count = id(new PhabricatorFeedStoryNotification())
-      ->countUnread($user);
+      ->countUnread($viewer);
 
     $json = array(
       'content' => $content,

src/applications/notification/controller/PhabricatorNotificationStatusController.php

@@ -3,7 +3,8 @@
 final class PhabricatorNotificationStatusController
   extends PhabricatorNotificationController {
 
-  public function processRequest() {
+  public function handleRequest(AphrontRequest $request) {
+
     try {
       $status = PhabricatorNotificationClient::getServerStatus();
       $status = $this->renderServerStatus($status);

src/applications/notification/controller/PhabricatorNotificationTestController.php

@@ -3,9 +3,8 @@
 final class PhabricatorNotificationTestController
   extends PhabricatorNotificationController {
 
-  public function processRequest() {
+  public function handleRequest(AphrontRequest $request) {
-    $request = $this->getRequest();
+    $viewer = $request->getViewer();
-    $viewer = $request->getUser();
 
     $story_type = 'PhabricatorNotificationTestFeedStory';
     $story_data = array(