1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 23:02:42 +01:00

Make the Diffusion warning about "svnlook" and PATH more clear

Summary:
See <https://discourse.phabricator-community.org/t/display-error-on-the-status-page-for-svn-repos/2443> for discussion.

The UI currently shows a misleading warning that looks like "found svnlook; can't find svnlook".

It actually means "found svnlook, but when Subversion wipes PATH before executing commit hooks, we will no longer be able to find it".

Test Plan: {F6240967}

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20210
This commit is contained in:
epriestley 2019-02-25 06:18:53 -08:00
parent 767afd1780
commit f61e825905

View file

@ -444,13 +444,15 @@ final class DiffusionRepositoryBasicsManagementPanel
id(new PHUIStatusItemView())
->setIcon(PHUIStatusItemView::ICON_WARNING, 'red')
->setTarget(
pht('Missing Binary %s', phutil_tag('tt', array(), $binary)))
->setNote(pht(
'Unable to find this binary in `%s`. '.
'You need to configure %s and include %s.',
'environment.append-paths',
$this->getEnvConfigLink(),
$path)));
pht('Commit Hooks: %s', phutil_tag('tt', array(), $binary)))
->setNote(
pht(
'The directory containing the "svnlook" binary is not '.
'listed in "environment.append-paths", so commit hooks '.
'(which execute with an empty "PATH") will not be able to '.
'find "svnlook". Add `%s` to %s.',
$path,
$this->getEnvConfigLink())));
}
}
}