revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-16 02:20:54 +01:00
Code Issues Releases Wiki Activity

(stable) Fix an issue where rejecting reviewers weren't powerful enough

Browse source 
Summary:
Previously, "reject" and "reject older" were separate statuses. Now, they're both shades of "reject".

Set the "older reject" flag properly when we find a non-current reject.

Test Plan:
  - User A accepts a revision.
  - User B rejects it.
  - Author updates it.
  - Before patch: incorrectly transitions to "accepted" ("older" reject is ignored).
  - After patch: correctly transitions to "needs review".

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17653
This commit is contained in:
epriestley 2017-04-11 09:51:01 -07:00
parent 944f7da486
commit f624c82381
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/editor/DifferentialTransactionEditor.php
View file

@ -672,6 +672,8 @@ final class DifferentialTransactionEditor
$active_phid = $active_diff->getPHID(); $active_phid = $active_diff->getPHID();
if ($reviewer->isRejected($active_phid)) { if ($reviewer->isRejected($active_phid)) {
$has_rejecting_reviewer = true; $has_rejecting_reviewer = true;
} else {
$has_rejecting_older_reviewer = true;
} }
break; break;
case DifferentialReviewerStatus::STATUS_REJECTED_OLDER: case DifferentialReviewerStatus::STATUS_REJECTED_OLDER: