Add PhabricatorFactSpec, for naming and formatting facts

Summary: Not totally sure about this but I think it's okay?

Test Plan: Loaded /fact/, got a more readable page.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1562

Differential Revision: https://secure.phabricator.com/D3090

src/__phutil_library_map__.php

@@ -638,6 +638,8 @@ phutil_register_library_map(array(
     'PhabricatorFactManagementStatusWorkflow' => 'applications/fact/management/PhabricatorFactManagementStatusWorkflow.php',
     'PhabricatorFactManagementWorkflow' => 'applications/fact/management/PhabricatorFactManagementWorkflow.php',
     'PhabricatorFactRaw' => 'applications/fact/storage/PhabricatorFactRaw.php',
+    'PhabricatorFactSimpleSpec' => 'applications/fact/spec/PhabricatorFactSimpleSpec.php',
+    'PhabricatorFactSpec' => 'applications/fact/spec/PhabricatorFactSpec.php',
     'PhabricatorFactUpdateIterator' => 'applications/fact/extract/PhabricatorFactUpdateIterator.php',
     'PhabricatorFeedBuilder' => 'applications/feed/builder/PhabricatorFeedBuilder.php',
     'PhabricatorFeedConstants' => 'applications/feed/constants/PhabricatorFeedConstants.php',

src/applications/fact/controller/PhabricatorFactHomeController.php

@@ -19,17 +19,32 @@
 final class PhabricatorFactHomeController extends PhabricatorFactController {
 
   public function processRequest() {
+    $request = $this->getRequest();
+    $user = $request->getUser();
+
+    $types = array(
+      '+N:*',
+      '+N:DREV',
+      'updated',
+    );
+
+    $engines = PhabricatorFactEngine::loadAllEngines();
+    $specs = PhabricatorFactSpec::newSpecsForFactTypes($engines, $types);
 
     $facts = id(new PhabricatorFactAggregate())->loadAllWhere(
-      'factType LIKE %> OR factType = %s',
+      'factType IN (%Ls)',
-      '+N:',
+      $types);
-      'updated');
 
     $rows = array();
     foreach ($facts as $fact) {
+      $spec = $specs[$fact->getFactType()];
+
+      $name = $spec->getName();
+      $value = $spec->formatValueForDisplay($user, $fact->getValueX());
+
       $rows[] = array(
-        phutil_escape_html($fact->getFactType()),
+        phutil_escape_html($name),
-        (int)$fact->getValueX(),
+        phutil_escape_html($value),
       );
     }
 

src/applications/fact/engine/PhabricatorFactCountEngine.php

@@ -21,6 +21,24 @@
  */
 final class PhabricatorFactCountEngine extends PhabricatorFactEngine {
 
+  public function getFactSpecs(array $fact_types) {
+    $results = array();
+    foreach ($fact_types as $type) {
+      if (!strncmp($type, '+N:', 3)) {
+        if ($type == '+N:*') {
+          $name = 'Total Objects';
+        } else {
+          $name = 'Total Objects of type '.substr($type, 3);
+        }
+
+        $results[] = id(new PhabricatorFactSimpleSpec($type))
+          ->setName($name)
+          ->setUnit(PhabricatorFactSimpleSpec::UNIT_COUNT);
+      }
+    }
+    return $results;
+  }
+
   public function shouldComputeRawFactsForObject(PhabricatorLiskDAO $object) {
     return true;
   }

src/applications/fact/engine/PhabricatorFactEngine.php

@@ -32,6 +32,10 @@ abstract class PhabricatorFactEngine {
     return $objects;
   }
 
+  public function getFactSpecs(array $fact_types) {
+    return array();
+  }
+
   public function shouldComputeRawFactsForObject(PhabricatorLiskDAO $object) {
     return false;
   }

src/applications/fact/engine/PhabricatorFactLastUpdatedEngine.php

@@ -21,6 +21,18 @@
  */
 final class PhabricatorFactLastUpdatedEngine extends PhabricatorFactEngine {
 
+  public function getFactSpecs(array $fact_types) {
+    $results = array();
+    foreach ($fact_types as $type) {
+      if ($type == 'updated') {
+        $results[] = id(new PhabricatorFactSimpleSpec($type))
+          ->setName('Facts Last Updated')
+          ->setUnit(PhabricatorFactSimpleSpec::UNIT_EPOCH);
+      }
+    }
+    return $results;
+  }
+
   public function shouldComputeAggregateFacts() {
     return true;
   }

src/applications/fact/spec/PhabricatorFactSimpleSpec.php

@@ -0,0 +1,54 @@
+<?php
+
+/*
+ * Copyright 2012 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+final class PhabricatorFactSimpleSpec extends PhabricatorFactSpec {
+
+  private $type;
+  private $name;
+  private $unit;
+
+  public function __construct($type) {
+    $this->type = $type;
+  }
+
+  public function getType() {
+    return $this->type;
+  }
+
+  public function setUnit($unit) {
+    $this->unit = $unit;
+    return $this;
+  }
+
+  public function getUnit() {
+    return $this->unit;
+  }
+
+  public function setName($name) {
+    $this->name = $name;
+    return $this;
+  }
+
+  public function getName() {
+    if ($this->name !== null) {
+      return $this->name;
+    }
+    return parent::getName();
+  }
+
+}

src/applications/fact/spec/PhabricatorFactSpec.php

@@ -0,0 +1,68 @@
+<?php
+
+/*
+ * Copyright 2012 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+abstract class PhabricatorFactSpec {
+
+  const UNIT_COUNT = 'unit-count';
+  const UNIT_EPOCH = 'unit-epoch';
+
+  public static function newSpecsForFactTypes(
+    array $engines,
+    array $fact_types) {
+    assert_instances_of($engines, 'PhabricatorFactEngine');
+
+    $map = array();
+    foreach ($engines as $engine) {
+      $specs = $engine->getFactSpecs($fact_types);
+      $specs = mpull($specs, null, 'getType');
+      $map += $specs;
+    }
+
+    foreach ($fact_types as $type) {
+      if (empty($map[$type])) {
+        $map[$type] = new PhabricatorFactSimpleSpec($type);
+      }
+    }
+
+    return $map;
+  }
+
+  abstract public function getType();
+
+  public function getUnit() {
+    return null;
+  }
+
+  public function getName() {
+    $type = $this->getType();
+    return "Fact ({$type})";
+  }
+
+  public function formatValueForDisplay(PhabricatorUser $user, $value) {
+    $unit = $this->getUnit();
+    switch ($unit) {
+      case self::UNIT_COUNT:
+        return number_format($value);
+      case self::UNIT_EPOCH:
+        return phabricator_datetime($value, $user);
+      default:
+        return $value;
+    }
+  }
+
+}