revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-09 16:32:39 +01:00
Code Issues Releases Wiki Activity

When changing the trigger type in the trigger editor, properly redraw the control

Browse source 
Summary: Ref T13269. I refactored this late in the game to organize things better and add table cells around stuff, and accidentally broke the relationship between the "Rule Type" selector and the value selector.

Test Plan: Switched rule type selector from "Change Status" to "Play Sound", saw secondary control update properly.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13269

Differential Revision: https://secure.phabricator.com/D20326
This commit is contained in:
epriestley 2019-03-26 11:44:55 -07:00
parent d347b102a1
commit f6658bf391
2 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
resources/celerity/map.php
View file

@ -433,7 +433,7 @@ return array(
'rsrc/js/application/transactions/behavior-show-older-transactions.js' => '600f440c',
'rsrc/js/application/transactions/behavior-transaction-comment-form.js' => '2bdadf1a',
'rsrc/js/application/transactions/behavior-transaction-list.js' => '9cec214e',
'rsrc/js/application/trigger/TriggerRule.js' => 'e4a816a4',
'rsrc/js/application/trigger/TriggerRule.js' => '1c60c3fc',
'rsrc/js/application/trigger/TriggerRuleControl.js' => '5faf27b9',
'rsrc/js/application/trigger/TriggerRuleEditor.js' => 'b49fd60c',
'rsrc/js/application/trigger/TriggerRuleType.js' => '4feea7d3',
@ -894,7 +894,7 @@ return array(
'syntax-default-css' => '055fc231',
'syntax-highlighting-css' => '4234f572',
'tokens-css' => 'ce5a50bd',
'trigger-rule' => 'e4a816a4',
'trigger-rule' => '1c60c3fc',
'trigger-rule-control' => '5faf27b9',
'trigger-rule-editor' => 'b49fd60c',
'trigger-rule-type' => '4feea7d3',

8
webroot/rsrc/js/application/trigger/TriggerRule.js
View file

@ -84,8 +84,8 @@ JX.install('TriggerRule', {
control.value = this.getType();
var on_change = JX.bind(this, this._onTypeChange);
JX.DOM.listen(control, 'onchange', null, on_change);
var on_change = JX.bind(this, this._onTypeChange, control);
JX.DOM.listen(control, 'change', null, on_change);
var attributes = {
className: 'type-cell'
@ -97,10 +97,8 @@ JX.install('TriggerRule', {
return this._typeCell;
},
_onTypeChange: function() {
var control = this._getTypeCell();
_onTypeChange: function(control) {
this.setType(control.value);
this._rebuildValueControl();
},