From f6748bc1907d946ffe5a0957964a5eb5fe90514f Mon Sep 17 00:00:00 2001 From: Jason Ge Date: Fri, 6 Apr 2012 01:26:20 -0700 Subject: [PATCH] The existing Audit code forgot to set authorPHID Summary: The audit tools has many false positive about Author Not Matching with Revision. The fix is to set the authorPHID which was missing in the existing code Test Plan: run reparse.php and it doesn't generate false positive result anymore. Reviewers: nh, epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2119 --- .../worker/owner/PhabricatorRepositoryCommitOwnersWorker.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/applications/repository/worker/owner/PhabricatorRepositoryCommitOwnersWorker.php b/src/applications/repository/worker/owner/PhabricatorRepositoryCommitOwnersWorker.php index cc46a3fc01..8450596517 100644 --- a/src/applications/repository/worker/owner/PhabricatorRepositoryCommitOwnersWorker.php +++ b/src/applications/repository/worker/owner/PhabricatorRepositoryCommitOwnersWorker.php @@ -111,6 +111,7 @@ final class PhabricatorRepositoryCommitOwnersWorker $revision_author_phid = $revision->getAuthorPHID(); $revision_reviewedby_phid = $revision->loadReviewedBy(); $commit_reviewedby_phid = $data->getCommitDetail('reviewerPHID'); + $commit_author_phid = $data->getCommitDetail('authorPHID'); if ($revision_author_phid !== $commit_author_phid) { $reasons[] = "Author Not Matching with Revision"; }