Fix an issue with pulling Subversion blame data

Summary:
Fixes T4067. The way `DiffusionCommitQuery` works prevents it from loading SVN identifiers in some cases without additional constraints, since "12345" might be an SVN revision 12345, or it might be the first 5 characters of a Git commit hash.

Introduce `withRepository()` as a shorthand for `withDefaultRepository()` + `withRepositoryIDs()`. This tells the query to:

  - Only look in the given repository; and
  - use the more liberal identifier resolution rules while doing so.

The practical impact this has is that blame tooltips in SVN work again. The other queries which are fixed here were never run in SVN (which doesn't have first-class branches or tags); I've cleaned them up only for completeness.

Test Plan:
  - Viewed blame in SVN, saw information again instead of empty tooltip.
  - Viewed brnaches/tags in Mercurial and Git.

{F79226}

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4067

Differential Revision: https://secure.phabricator.com/D7523

src/applications/diffusion/controller/DiffusionBranchTableController.php

@@ -36,7 +36,7 @@ final class DiffusionBranchTableController extends DiffusionController {
       $commits = id(new DiffusionCommitQuery())
         ->setViewer($viewer)
         ->withIdentifiers(mpull($branches, 'getHeadCommitIdentifier'))
-        ->withRepositoryIDs(array($repository->getID()))
+        ->withRepository($repository)
         ->execute();
 
       $view = id(new DiffusionBranchTableView())

src/applications/diffusion/controller/DiffusionBrowseFileController.php

@@ -555,7 +555,7 @@ final class DiffusionBrowseFileController extends DiffusionBrowseController {
     if ($commits) {
       $commits = id(new DiffusionCommitQuery())
         ->setViewer($viewer)
-        ->withRepositoryIDs(array($drequest->getRepository()->getID()))
+        ->withRepository($drequest->getRepository())
         ->withIdentifiers($commits)
         ->execute();
       $commits = mpull($commits, null, 'getCommitIdentifier');

src/applications/diffusion/controller/DiffusionRepositoryController.php

@@ -268,7 +268,7 @@ final class DiffusionRepositoryController extends DiffusionController {
     $commits = id(new DiffusionCommitQuery())
       ->setViewer($viewer)
       ->withIdentifiers(mpull($branches, 'getHeadCommitIdentifier'))
-      ->withRepositoryIDs(array($drequest->getRepository()->getID()))
+      ->withRepository($drequest->getRepository())
       ->execute();
 
     $table = id(new DiffusionBranchTableView())
@@ -332,7 +332,7 @@ final class DiffusionRepositoryController extends DiffusionController {
     $commits = id(new DiffusionCommitQuery())
       ->setViewer($viewer)
       ->withIdentifiers(mpull($tags, 'getCommitIdentifier'))
-      ->withRepositoryIDs(array($drequest->getRepository()->getID()))
+      ->withRepository($drequest->getRepository())
       ->needCommitData(true)
       ->execute();
 

src/applications/diffusion/controller/DiffusionTagListController.php

@@ -50,7 +50,7 @@ final class DiffusionTagListController extends DiffusionController {
     } else {
       $commits = id(new DiffusionCommitQuery())
         ->setViewer($viewer)
-        ->withRepositoryIDs(array($repository->getID()))
+        ->withRepository($repository)
         ->withIdentifiers(mpull($tags, 'getCommitIdentifier'))
         ->needCommitData(true)
         ->execute();

src/applications/diffusion/query/DiffusionCommitQuery.php

@@ -52,6 +52,17 @@ final class DiffusionCommitQuery
     return $this;
   }
 
+
+  /**
+   * Look up commits in a specific repository. This is a shorthand for calling
+   * @{method:withDefaultRepository} and @{method:withRepositoryIDs}.
+   */
+  public function withRepository(PhabricatorRepository $repository) {
+    $this->withDefaultRepository($repository);
+    $this->withRepositoryIDs(array($repository->getID()));
+    return $this;
+  }
+
   public function needCommitData($need) {
     $this->needCommitData = $need;
     return $this;

src/applications/diffusion/query/DiffusionRenameHistoryQuery.php

@@ -81,7 +81,7 @@ final class DiffusionRenameHistoryQuery {
     $commit = id(new DiffusionCommitQuery())
       ->setViewer($this->viewer)
       ->withIdentifiers(array($commit_identifier))
-      ->withDefaultRepository($this->request->getRepository())
+      ->withRepository($this->request->getRepository())
       ->executeOne();
     return $commit->getID();
   }