From f6c98a55a4ed3b4f2c0e6bcced53da4e04883f46 Mon Sep 17 00:00:00 2001
From: Aviv Eyal <avivey@gmail.com>
Date: Sun, 29 Nov 2015 23:13:26 +0000
Subject: [PATCH] Don't raise setup warning for "bad version" if the binary is
 not there

Test Plan: warning is not in warnings list.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D14594
---
 .../config/check/PhabricatorBinariesSetupCheck.php             | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/applications/config/check/PhabricatorBinariesSetupCheck.php b/src/applications/config/check/PhabricatorBinariesSetupCheck.php
index 59dc3a78ab..c33dcae36f 100644
--- a/src/applications/config/check/PhabricatorBinariesSetupCheck.php
+++ b/src/applications/config/check/PhabricatorBinariesSetupCheck.php
@@ -96,10 +96,11 @@ final class PhabricatorBinariesSetupCheck extends PhabricatorSetupCheck {
           'You have at least one repository configured which uses this '.
           'version control system. It will not work without the VCS binary.');
         $this->raiseWarning($binary, $message);
+        continue;
       }
 
       $version = null;
-      switch ($binary) {
+      switch ($vcs['versionControlSystem']) {
         case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
           $minimum_version = null;
           $bad_versions = array();