From f717e4b5634c178af8f763ff83846dd405e09404 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Mon, 8 May 2017 19:47:35 -0700 Subject: [PATCH] Clean up some Fund language Summary: Ref T12685. Cleans up various Fund language nits. Test Plan: Read carefully. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T12685 Differential Revision: https://secure.phabricator.com/D17856 --- src/applications/fund/query/FundBackerSearchEngine.php | 1 + .../fund/xaction/FundInitiativeNameTransaction.php | 2 +- .../fund/xaction/FundInitiativeStatusTransaction.php | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/applications/fund/query/FundBackerSearchEngine.php b/src/applications/fund/query/FundBackerSearchEngine.php index c275e58a0c..ba4b3bc39e 100644 --- a/src/applications/fund/query/FundBackerSearchEngine.php +++ b/src/applications/fund/query/FundBackerSearchEngine.php @@ -126,6 +126,7 @@ final class FundBackerSearchEngine } $table = id(new AphrontTableView($rows)) + ->setNoDataString(pht('No backers found.')) ->setHeaders( array( pht('Initiative'), diff --git a/src/applications/fund/xaction/FundInitiativeNameTransaction.php b/src/applications/fund/xaction/FundInitiativeNameTransaction.php index 5883c32ce2..4a47c20a17 100644 --- a/src/applications/fund/xaction/FundInitiativeNameTransaction.php +++ b/src/applications/fund/xaction/FundInitiativeNameTransaction.php @@ -37,7 +37,7 @@ final class FundInitiativeNameTransaction $this->renderObject()); } else { return pht( - '%s renamed %s initiative from %s to %s.', + '%s renamed %s from %s to %s.', $this->renderAuthor(), $this->renderObject(), $this->renderOldValue(), diff --git a/src/applications/fund/xaction/FundInitiativeStatusTransaction.php b/src/applications/fund/xaction/FundInitiativeStatusTransaction.php index 688c8b52c4..5c0af0e705 100644 --- a/src/applications/fund/xaction/FundInitiativeStatusTransaction.php +++ b/src/applications/fund/xaction/FundInitiativeStatusTransaction.php @@ -28,12 +28,12 @@ final class FundInitiativeStatusTransaction public function getTitleForFeed() { if ($this->getNewValue() == FundInitiative::STATUS_CLOSED) { return pht( - '%s closed the initiative %s.', + '%s closed %s.', $this->renderAuthor(), $this->renderObject()); } else { return pht( - '%s reopened the initiative %s.', + '%s reopened %s.', $this->renderAuthor(), $this->renderObject()); }