revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Fix regression in DiffusionDiffQueryConduitAPIMethod

Browse source 
Summary:
Fix the following error you may encounter in production:

    Too few arguments to function DiffusionDiffQueryConduitAPIMethod::getDefaultParser(), 0 passed in /var/www/phorge/src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php on line 156 and exactly 1 expected

It was caused by the lack of a new mandatory parameter in a method.

Closes T15649

Test Plan: Check with your big eyes that a ConduitAPIRequest is passed to getDefaultParser().

Reviewers: avivey, O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15649

Differential Revision: https://we.phorge.it/D25444
This commit is contained in:
Valerio Bozzolan 2023-10-10 07:16:05 +02:00
parent 71b273a622
commit f727f17bc2
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php
View file

@ -153,7 +153,7 @@ final class DiffusionDiffQueryConduitAPIMethod
$arcanist_changes = DiffusionPathChange::convertToArcanistChanges( $arcanist_changes = DiffusionPathChange::convertToArcanistChanges(
$path_changes); $path_changes);
$parser = $this->getDefaultParser(); $parser = $this->getDefaultParser($request);
$parser->setChanges($arcanist_changes); $parser->setChanges($arcanist_changes);
$parser->forcePath($path->getPath()); $parser->forcePath($path->getPath());
$changes = $parser->parseDiff($raw_diff); $changes = $parser->parseDiff($raw_diff);