revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 08:12:40 +01:00
Code Issues Releases Wiki Activity

Fix Diviner strlen(null) error when clicking on a link

Browse source 
Summary:
Fix issue whereby clicking on a link in Diviner (eg https://my.phorge.site/diviner/find/?name=Differential_User_Guide&type=article&jump=1) results in a strlen(null) error under PHP 8.1

Fixes T15635

Test Plan:
* Go into the Diviner differential page /book/phorge/article/differential/
* Click on the link to Differential User Guide: Inline Comments

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15635

Differential Revision: https://we.phorge.it/D25433
This commit is contained in:
sten 2023-09-05 17:02:58 +01:00
parent 1720209f16
commit f7d9d95b79
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/diviner/controller/DivinerFindController.php
View file

@ -32,7 +32,7 @@ final class DivinerFindController extends DivinerController {
} }
$context = $request->getStr('context'); $context = $request->getStr('context');
if (strlen($context)) { if (phutil_nonempty_string($context)) {
$query->withContexts(array($context)); $query->withContexts(array($context));
} }