From f8113aecdcbe76333cd73847fb8c3748556a886e Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 19 Jan 2018 06:52:59 -0800
Subject: [PATCH] Make bulk edit <select /> fields a little more natrual and
 set options for subtype transactions

Summary:
Ref T13025. This is some minor technical stuff: make the "select" bulk edit type a little more consistent with other types by passing data down instead of having it reach up the stack. This simplifies the implementation of a custom field "select" in a future change.

Also, provide an option list to the "select" edit field for object subtypes. This is only accessible via Conduit so it currently never actually renders anything in the UI, but with the bulk edit stuff we get some initialization order issues if we don't set anything. This will also make any future changes which expose subtypes more broadly more straightforward.

Test Plan:
  - Bulk edited "select" fields, like "Status" and "Priority".
  - No more fatal when trying to `getOptions()` internally on the subtype field.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13025

Differential Revision: https://secure.phabricator.com/D18878
---
 .../transactions/bulk/type/BulkSelectParameterType.php   | 9 ++++++++-
 .../editfield/PhabricatorSelectEditField.php             | 3 ++-
 .../PhabricatorSubtypeEditEngineExtension.php            | 6 +++++-
 3 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/src/applications/transactions/bulk/type/BulkSelectParameterType.php b/src/applications/transactions/bulk/type/BulkSelectParameterType.php
index d1cfc5125b..2f0ba863ef 100644
--- a/src/applications/transactions/bulk/type/BulkSelectParameterType.php
+++ b/src/applications/transactions/bulk/type/BulkSelectParameterType.php
@@ -3,8 +3,15 @@
 final class BulkSelectParameterType
   extends BulkParameterType {
 
+  private $options;
+
+  public function setOptions(array $options) {
+    $this->options = $options;
+    return $this;
+  }
+
   public function getOptions() {
-    return $this->getField()->getOptions();
+    return $this->options;
   }
 
   public function getPHUIXControlType() {
diff --git a/src/applications/transactions/editfield/PhabricatorSelectEditField.php b/src/applications/transactions/editfield/PhabricatorSelectEditField.php
index aacd67f5a8..7e98d84b2f 100644
--- a/src/applications/transactions/editfield/PhabricatorSelectEditField.php
+++ b/src/applications/transactions/editfield/PhabricatorSelectEditField.php
@@ -55,7 +55,8 @@ final class PhabricatorSelectEditField
   }
 
   protected function newBulkParameterType() {
-    return new BulkSelectParameterType();
+    return id(new BulkSelectParameterType())
+      ->setOptions($this->getOptions());
   }
 
   private function getCanonicalValue($value) {
diff --git a/src/applications/transactions/engineextension/PhabricatorSubtypeEditEngineExtension.php b/src/applications/transactions/engineextension/PhabricatorSubtypeEditEngineExtension.php
index a47a4d1b55..260c0d2acf 100644
--- a/src/applications/transactions/engineextension/PhabricatorSubtypeEditEngineExtension.php
+++ b/src/applications/transactions/engineextension/PhabricatorSubtypeEditEngineExtension.php
@@ -30,6 +30,9 @@ final class PhabricatorSubtypeEditEngineExtension
 
     $subtype_type = PhabricatorTransactions::TYPE_SUBTYPE;
 
+    $map = $object->newEditEngineSubtypeMap();
+    $options = mpull($map, 'getName');
+
     $subtype_field = id(new PhabricatorSelectEditField())
       ->setKey(self::EDITKEY)
       ->setLabel(pht('Subtype'))
@@ -41,7 +44,8 @@ final class PhabricatorSubtypeEditEngineExtension
       ->setTransactionType($subtype_type)
       ->setConduitDescription(pht('Change the object subtype.'))
       ->setConduitTypeDescription(pht('New object subtype key.'))
-      ->setValue($object->getEditEngineSubtype());
+      ->setValue($object->getEditEngineSubtype())
+      ->setOptions($options);
 
     return array(
       $subtype_field,