Fix double escaping in phutil_tag

Summary:
I wasn't able to reproduce the "recursion detected" in real web request but I saw lots of 1073741824 refcounts in `debug_zval_dump()` of $object.
I'm not sure how that happens.

Test Plan: D4807#4

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2432

Differential Revision: https://secure.phabricator.com/D4839

src/applications/directory/controller/PhabricatorDirectoryMainController.php

@@ -143,8 +143,9 @@ final class PhabricatorDirectoryMainController
     if (!$tasks) {
       return $this->renderMiniPanel(
         'No "Needs Triage" Tasks',
+        hsprintf(
           'No tasks in <a href="/project/">projects you are a member of</a> '.
-        'need triage.');
+          'need triage.'));
     }
 
     $panel = new AphrontPanelView();

src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php

@@ -96,6 +96,6 @@ abstract class PhabricatorRepositoryCommitParserWorker
       ->load($commit->getRepositoryID());
     $link = DiffusionView::linkCommit($repository,
                                       $commit->getCommitIdentifier());
-    return $link.$suffix;
+    return hsprintf('%s%s', $link, $suffix);
   }
 }

src/infrastructure/daemon/workers/PhabricatorWorker.php

@@ -151,9 +151,7 @@ abstract class PhabricatorWorker {
 
   public function renderForDisplay() {
     $data = PhutilReadableSerializer::printableValue($this->data);
-    $data = phutil_escape_html($data);
+    return phutil_tag('pre', array(), $data);
-    $data = '<pre>'.$data.'</pre>';
-    return $data;
   }
 
 }

src/view/control/AphrontTokenizerTemplateView.php

@@ -84,7 +84,7 @@ final class AphrontTokenizerTemplateView extends AphrontView {
             'type'  => 'hidden',
             'name'  => $input_name,
             'value' => $key,
-          )).
+          )),
         phutil_tag('span', array('class' => 'jx-tokenizer-x-placeholder'), ''),
       ));
   }