revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 16:22:43 +01:00
Code Issues Releases Wiki Activity

Fix call to non-existing newEmptyValue() in PhabricatorDashboardPortalProfileMenuEngine

Browse source 
Summary:
`PhabricatorDashboardPortalProfileMenuEngine` calls `$this->newEmptyValue()` but neither `PhabricatorDashboardPortalProfileMenuEngine` nor its parent `PhabricatorProfileMenuEngine` define a `newEmptyValue()` method.
Thus use existing `newNoContentView()` in parent `PhabricatorProfileMenuEngine` (which according to its string output is supposed to cover this case).

Test Plan:
Go to a Portal with no content. Before applying the patch, Phorge shows the message defined in the parent class `PhabricatorProfileMenuEngine`: `No Content`; `No visible menu items can render content.`
After applying this change, it correctly shows the message defined in `PhabricatorDashboardPortalProfileMenuEngine`: `No Portal Content`; `None of the visible menu items in this portal can render any content.`

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25648
This commit is contained in:
Andre Klapper 2024-05-16 13:15:29 +02:00
parent ed9d212013
commit f8b8d8876d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/dashboard/engine/PhabricatorDashboardPortalProfileMenuEngine.php
View file

@ -41,7 +41,7 @@ final class PhabricatorDashboardPortalProfileMenuEngine
pht('New Portal'),
pht('Use "Edit Menu" to add menu items to this portal.'));
} else {
return $this->newEmptyValue(
return $this->newNoContentView(
pht('No Portal Content'),
pht(
'None of the visible menu items in this portal can render any '.