From f8d8156ccc0dbe7d9a650f4432a8cd8c001d79cc Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 21 May 2013 15:44:44 -0700 Subject: [PATCH] Fix weird "0" notification numbers Summary: The JsShrink change swapped an "== 0" for "=== 0" in JS, but we're currently sending a string down. Fixes T3230. Test Plan: I'm not 100% sure this actually fixes it but probably? Let me know if you still see it. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T3230 Differential Revision: https://secure.phabricator.com/D5997 --- .../controller/PhabricatorNotificationPanelController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/notification/controller/PhabricatorNotificationPanelController.php b/src/applications/notification/controller/PhabricatorNotificationPanelController.php index 19a811fe4e..567aec38d5 100644 --- a/src/applications/notification/controller/PhabricatorNotificationPanelController.php +++ b/src/applications/notification/controller/PhabricatorNotificationPanelController.php @@ -43,7 +43,7 @@ final class PhabricatorNotificationPanelController $json = array( 'content' => $content, - 'number' => $unread_count, + 'number' => (int)$unread_count, ); return id(new AphrontAjaxResponse())->setContent($json);