revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 17:02:41 +01:00
Code Issues Releases Wiki Activity

Add flexible line height to remarkup headers

Browse source 
Summary:
The text in remarkup has a fixed line height. The headers will have the same fixed line height, even if their font size can be bigger than this line height. Especially on mobile this results in ugly sticked together lines which are less readable.

This revision will give the header a flexible line height of `1.3`. Unitless means relative to the font size.

| Before    | After     |
|-----------|-----------|
| {F717418} | {F717419} |

(I have moved the same margin attribute for every `h{2-6}` into the new declaration.)

Close T15716.

Test Plan: Just checkout and look in wiki articles with headers to see if everything looks nice and neat.

Reviewers: O1 Blessed Committers, 20after4

Reviewed By: O1 Blessed Committers, 20after4

Subscribers: 20after4, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15716

Differential Revision: https://we.phorge.it/D25523
This commit is contained in:
Benjamin Kausch 2024-01-22 18:04:39 +01:00
parent 6a30dc039e
commit f8db94f2bf
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/celerity/map.php
View file

@ -9,7 +9,7 @@ return array(
'names' => array( 'names' => array(
'conpherence.pkg.css' => '2f25eb4f', 'conpherence.pkg.css' => '2f25eb4f',
'conpherence.pkg.js' => '020aebcf', 'conpherence.pkg.js' => '020aebcf',
'core.pkg.css' => '4e0e22fb', 'core.pkg.css' => 'c753df75',
'core.pkg.js' => '2eeda9e0', 'core.pkg.js' => '2eeda9e0',
'dark-console.pkg.js' => '187792c2', 'dark-console.pkg.js' => '187792c2',
'differential.pkg.css' => '2431def2', 'differential.pkg.css' => '2431def2',
@ -109,7 +109,7 @@ return array(
'rsrc/css/application/tokens/tokens.css' => 'ce5a50bd', 'rsrc/css/application/tokens/tokens.css' => 'ce5a50bd',
'rsrc/css/application/uiexample/example.css' => 'b4795059', 'rsrc/css/application/uiexample/example.css' => 'b4795059',
'rsrc/css/core/core.css' => 'b3a5928e', 'rsrc/css/core/core.css' => 'b3a5928e',
'rsrc/css/core/remarkup.css' => 'b251d2e7', 'rsrc/css/core/remarkup.css' => 'd91c2ee8',
'rsrc/css/core/syntax.css' => '548567f6', 'rsrc/css/core/syntax.css' => '548567f6',
'rsrc/css/core/z-index.css' => 'ac3bfcd4', 'rsrc/css/core/z-index.css' => 'ac3bfcd4',
'rsrc/css/diviner/diviner-shared.css' => '4bd263b0', 'rsrc/css/diviner/diviner-shared.css' => '4bd263b0',
@ -798,7 +798,7 @@ return array(
'phabricator-object-selector-css' => 'ee77366f', 'phabricator-object-selector-css' => 'ee77366f',
'phabricator-phtize' => '2f1db1ed', 'phabricator-phtize' => '2f1db1ed',
'phabricator-prefab' => '5793d835', 'phabricator-prefab' => '5793d835',
'phabricator-remarkup-css' => 'b251d2e7', 'phabricator-remarkup-css' => 'd91c2ee8',
'phabricator-remarkup-metadata' => 'e40c4991', 'phabricator-remarkup-metadata' => 'e40c4991',
'phabricator-search-results-css' => '9ea70ace', 'phabricator-search-results-css' => '9ea70ace',
'phabricator-shaped-request' => '995f5102', 'phabricator-shaped-request' => '995f5102',

10
webroot/rsrc/css/core/remarkup.css
View file

@ -174,29 +174,29 @@
list-style-type: none; list-style-type: none;
} }
.phabricator-remarkup .remarkup-header {
line-height: 1.4;
margin: 1em 0 0.75em;
}
.phabricator-remarkup h2.remarkup-header { .phabricator-remarkup h2.remarkup-header {
font-size: 28px; font-size: 28px;
margin: 1em 0 0.75em;
} }
.phabricator-remarkup h3.remarkup-header { .phabricator-remarkup h3.remarkup-header {
font-size: 24px; font-size: 24px;
margin: 1em 0 0.75em;
} }
.phabricator-remarkup h4.remarkup-header { .phabricator-remarkup h4.remarkup-header {
font-size: 22px; font-size: 22px;
margin: 1em 0 0.75em;
} }
.phabricator-remarkup h5.remarkup-header { .phabricator-remarkup h5.remarkup-header {
font-size: 18px; font-size: 18px;
margin: 1em 0 0.75em;
} }
.phabricator-remarkup h6.remarkup-header { .phabricator-remarkup h6.remarkup-header {
font-size: 16px; font-size: 16px;
margin: 1em 0 0.75em;
} }
.phabricator-remarkup blockquote { .phabricator-remarkup blockquote {