From f967678236775a8dd9d08a34f594d9dbfc3c2358 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 26 Jun 2014 14:07:10 -0700
Subject: [PATCH] Ignore `#hashtag` implicit project tags which have no effect

Summary:
Fixes T5489. Currently, if you make a `#proj` comment on an object already tagged with `#proj`, you get a "no effect" dialog.

Instead, continue if these transactions produce no effect (this is normal/expected, and consistent with `@user`).

Test Plan: Made two `#proj` comments in a row on a revision.

Reviewers: joshuaspence, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T5489

Differential Revision: https://secure.phabricator.com/D9745
---
 .../editor/PhabricatorApplicationTransactionEditor.php           | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
index 258720fbb8..cbabcc354c 100644
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -1131,6 +1131,7 @@ abstract class PhabricatorApplicationTransactionEditor
       if ($phids) {
         $edge_type = PhabricatorEdgeConfig::TYPE_OBJECT_HAS_PROJECT;
         $block_xactions[] = newv(get_class(head($xactions)), array())
+          ->setIgnoreOnNoEffect(true)
           ->setTransactionType(PhabricatorTransactions::TYPE_EDGE)
           ->setMetadataValue('edge:type', $edge_type)
           ->setNewValue(array('+' => $phids));