From f9e31089386caa84329416e938a7db2e51942c06 Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 16 Jun 2016 03:44:34 -0700 Subject: [PATCH] Fix an issue with AuthProviderConfig handles Summary: Fixes T11156. These were never correct, but also never actually used until I made timelines load object handles unconditionally in D16111. Test Plan: Viewed an auth provider with transactions, no more fatal. Reviewers: chad Reviewed By: chad Maniphest Tasks: T11156 Differential Revision: https://secure.phabricator.com/D16128 --- .../auth/phid/PhabricatorAuthAuthProviderPHIDType.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/applications/auth/phid/PhabricatorAuthAuthProviderPHIDType.php b/src/applications/auth/phid/PhabricatorAuthAuthProviderPHIDType.php index e91b66e647..bf79ea8743 100644 --- a/src/applications/auth/phid/PhabricatorAuthAuthProviderPHIDType.php +++ b/src/applications/auth/phid/PhabricatorAuthAuthProviderPHIDType.php @@ -30,9 +30,11 @@ final class PhabricatorAuthAuthProviderPHIDType extends PhabricatorPHIDType { array $objects) { foreach ($handles as $phid => $handle) { - $provider = $objects[$phid]; + $provider = $objects[$phid]->getProvider(); - $handle->setName($provider->getProviderName()); + if ($provider) { + $handle->setName($provider->getProviderName()); + } } }