Rough in EditEngine for Maniphest

Summary:
Ref T9132. I'm going hold this until after the release cut since it isn't going to land completely smoothly, but I think I can prep it today/tomorrow and hopefully get it close enough to working to put in HEAD on Saturday after the push.

This adds the basics: new EditEngine, new EditController, and new `maniphest.edit` API endpoint.

I put the new stuff at `editpro/` for now until it works a little better.

Some notes on stuff this is dropping/changing/not-working-yet:

  - Preview for the description. I'd rather solve this by putting a "Preview" button on every Remarkup area if we want to retain it. Particularly, it does not generalize to adding custom remarkup fields in its current form. See also T3967.
  - Per-field policies are no longer enforced. They were never truly enforced anyway (for example, any user who can edit a task has always been able to edit every field via Conduit or email actions or Herald, where Herald supports things), and only really served as a hint to users. I think we can obsolete this by having installs hide/lock these fields instead. This is a desirable outcome for me, since I don't like retaining these policies and the idea of truly enforcing them properly is worrisome. These were originally added for Uber as an onboarding sort of thing. I'll prepare users for this in greater detail in the documentation.
  - Couple of minor bugs with ordering / defaults / only-one-owner-allowed in this diff that I'll clean up in future diffs before this stuff lands.
  - I don't have a concrete plan on "Create Similar Task" / "Clone" yet (do you have thoughts? Is this worth trying to do in every application?). I'll probably just mostly mimic the current behavior.

Test Plan: I'll vet this more thoroughly in followups, just banged around some tasks for now and created/edited via the API.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9132

Differential Revision: https://secure.phabricator.com/D14659

src/__phutil_library_map__.php

@@ -1260,6 +1260,8 @@ phutil_register_library_map(array(
     'ManiphestDefaultEditCapability' => 'applications/maniphest/capability/ManiphestDefaultEditCapability.php',
     'ManiphestDefaultViewCapability' => 'applications/maniphest/capability/ManiphestDefaultViewCapability.php',
     'ManiphestEditAssignCapability' => 'applications/maniphest/capability/ManiphestEditAssignCapability.php',
+    'ManiphestEditConduitAPIMethod' => 'applications/maniphest/conduit/ManiphestEditConduitAPIMethod.php',
+    'ManiphestEditEngine' => 'applications/maniphest/editor/ManiphestEditEngine.php',
     'ManiphestEditPoliciesCapability' => 'applications/maniphest/capability/ManiphestEditPoliciesCapability.php',
     'ManiphestEditPriorityCapability' => 'applications/maniphest/capability/ManiphestEditPriorityCapability.php',
     'ManiphestEditProjectsCapability' => 'applications/maniphest/capability/ManiphestEditProjectsCapability.php',
@@ -1299,6 +1301,7 @@ phutil_register_library_map(array(
     'ManiphestTaskDetailController' => 'applications/maniphest/controller/ManiphestTaskDetailController.php',
     'ManiphestTaskEditBulkJobType' => 'applications/maniphest/bulk/ManiphestTaskEditBulkJobType.php',
     'ManiphestTaskEditController' => 'applications/maniphest/controller/ManiphestTaskEditController.php',
+    'ManiphestTaskEditProController' => 'applications/maniphest/controller/ManiphestTaskEditProController.php',
     'ManiphestTaskHasCommitEdgeType' => 'applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php',
     'ManiphestTaskHasMockEdgeType' => 'applications/maniphest/edge/ManiphestTaskHasMockEdgeType.php',
     'ManiphestTaskHasRevisionEdgeType' => 'applications/maniphest/edge/ManiphestTaskHasRevisionEdgeType.php',
@@ -5235,6 +5238,8 @@ phutil_register_library_map(array(
     'ManiphestDefaultEditCapability' => 'PhabricatorPolicyCapability',
     'ManiphestDefaultViewCapability' => 'PhabricatorPolicyCapability',
     'ManiphestEditAssignCapability' => 'PhabricatorPolicyCapability',
+    'ManiphestEditConduitAPIMethod' => 'PhabricatorEditEngineAPIMethod',
+    'ManiphestEditEngine' => 'PhabricatorEditEngine',
     'ManiphestEditPoliciesCapability' => 'PhabricatorPolicyCapability',
     'ManiphestEditPriorityCapability' => 'PhabricatorPolicyCapability',
     'ManiphestEditProjectsCapability' => 'PhabricatorPolicyCapability',
@@ -5288,6 +5293,7 @@ phutil_register_library_map(array(
     'ManiphestTaskDetailController' => 'ManiphestController',
     'ManiphestTaskEditBulkJobType' => 'PhabricatorWorkerBulkJobType',
     'ManiphestTaskEditController' => 'ManiphestController',
+    'ManiphestTaskEditProController' => 'ManiphestController',
     'ManiphestTaskHasCommitEdgeType' => 'PhabricatorEdgeType',
     'ManiphestTaskHasMockEdgeType' => 'PhabricatorEdgeType',
     'ManiphestTaskHasRevisionEdgeType' => 'PhabricatorEdgeType',

src/applications/maniphest/application/PhabricatorManiphestApplication.php

@@ -69,6 +69,8 @@ final class PhabricatorManiphestApplication extends PhabricatorApplication {
         ),
         'export/(?P<key>[^/]+)/' => 'ManiphestExportController',
         'subpriority/' => 'ManiphestSubpriorityController',
+        $this->getEditRoutePattern('editpro/')
+          => 'ManiphestTaskEditProController',
       ),
     );
   }

src/applications/maniphest/conduit/ManiphestEditConduitAPIMethod.php

@@ -0,0 +1,19 @@
+<?php
+
+final class ManiphestEditConduitAPIMethod
+  extends PhabricatorEditEngineAPIMethod {
+
+  public function getAPIMethodName() {
+    return 'maniphest.edit';
+  }
+
+  public function newEditEngine() {
+    return new ManiphestEditEngine();
+  }
+
+  public function getMethodSummary() {
+    return pht(
+      'Apply transactions to create a new task or edit an existing one.');
+  }
+
+}

src/applications/maniphest/controller/ManiphestTaskEditProController.php

@@ -0,0 +1,11 @@
+<?php
+
+final class ManiphestTaskEditProController extends ManiphestController {
+
+  public function handleRequest(AphrontRequest $request) {
+    return id(new ManiphestEditEngine())
+      ->setController($this)
+      ->buildResponse();
+  }
+
+}

src/applications/maniphest/editor/ManiphestEditEngine.php

@@ -0,0 +1,113 @@
+<?php
+
+final class ManiphestEditEngine
+  extends PhabricatorEditEngine {
+
+  const ENGINECONST = 'maniphest.task';
+
+  public function getEngineName() {
+    return pht('Maniphest Tasks');
+  }
+
+  public function getEngineApplicationClass() {
+    return 'PhabricatorManiphestApplication';
+  }
+
+  protected function newEditableObject() {
+    return ManiphestTask::initializeNewTask($this->getViewer());
+  }
+
+  protected function newObjectQuery() {
+    return id(new ManiphestTaskQuery());
+  }
+
+  protected function getObjectCreateTitleText($object) {
+    return pht('Create New Task');
+  }
+
+  protected function getObjectEditTitleText($object) {
+    return pht('Edit %s %s', $object->getMonogram(), $object->getTitle());
+  }
+
+  protected function getObjectEditShortText($object) {
+    return $object->getMonogram();
+  }
+
+  protected function getObjectCreateShortText() {
+    return pht('Create Task');
+  }
+
+  protected function getCommentViewHeaderText($object) {
+    $is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');
+    if (!$is_serious) {
+      return pht('Weigh In');
+    }
+
+    return parent::getCommentViewHeaderText($object);
+  }
+
+  protected function getObjectViewURI($object) {
+    return '/'.$object->getMonogram();
+  }
+
+  protected function buildCustomEditFields($object) {
+    // See T4819.
+    $status_map = ManiphestTaskStatus::getTaskStatusMap();
+    $dup_status = ManiphestTaskStatus::getDuplicateStatus();
+    if ($object->getStatus() != $dup_status) {
+      unset($status_map[$dup_status]);
+    }
+
+    $owner_phid = $object->getOwnerPHID();
+    if ($owner_phid) {
+      $owner_value = array($owner_phid);
+    } else {
+      $owner_value = array();
+    }
+
+    $priority_map = ManiphestTaskPriority::getTaskPriorityMap();
+
+    return array(
+      id(new PhabricatorTextEditField())
+        ->setKey('title')
+        ->setLabel(pht('Title'))
+        ->setDescription(pht('Name of the paste.'))
+        ->setTransactionType(ManiphestTransaction::TYPE_TITLE)
+        ->setIsRequired(true)
+        ->setValue($object->getTitle()),
+      id(new PhabricatorSelectEditField())
+        ->setKey('status')
+        ->setLabel(pht('Status'))
+        ->setDescription(pht('Status of the task.'))
+        ->setTransactionType(ManiphestTransaction::TYPE_STATUS)
+        ->setValue($object->getStatus())
+        ->setOptions($status_map),
+      id(new PhabricatorUsersEditField())
+        ->setKey('assigned')
+        ->setAliases(array('assign', 'assignee'))
+        ->setLabel(pht('Assigned To'))
+        ->setDescription(pht('User who is responsible for the task.'))
+        ->setTransactionType(ManiphestTransaction::TYPE_OWNER)
+        ->setValue($owner_value),
+      id(new PhabricatorSelectEditField())
+        ->setKey('priority')
+        ->setLabel(pht('Priority'))
+        ->setDescription(pht('Priority of the task.'))
+        ->setTransactionType(ManiphestTransaction::TYPE_PRIORITY)
+        ->setValue($object->getPriority())
+        ->setOptions($priority_map),
+      id(new PhabricatorRemarkupEditField())
+        ->setKey('description')
+        ->setLabel(pht('Description'))
+        ->setDescription(pht('Task description.'))
+        ->setTransactionType(ManiphestTransaction::TYPE_DESCRIPTION)
+        ->setValue($object->getDescription()),
+    );
+  }
+
+  protected function getEditorURI() {
+    // TODO: Remove when cutting over.
+    return $this->getApplication()->getApplicationURI('editpro/');
+  }
+
+}

src/applications/maniphest/editor/ManiphestTransactionEditor.php

@@ -716,5 +716,34 @@ final class ManiphestTransactionEditor
     return array($dst->getPriority(), $sub);
   }
 
+  protected function validateTransaction(
+    PhabricatorLiskDAO $object,
+    $type,
+    array $xactions) {
+
+    $errors = parent::validateTransaction($object, $type, $xactions);
+
+    switch ($type) {
+      case ManiphestTransaction::TYPE_TITLE:
+        $missing = $this->validateIsEmptyTextField(
+          $object->getTitle(),
+          $xactions);
+
+        if ($missing) {
+          $error = new PhabricatorApplicationTransactionValidationError(
+            $type,
+            pht('Required'),
+            pht('Task title is required.'),
+            nonempty(last($xactions), null));
+
+          $error->setIsMissingFieldError(true);
+          $errors[] = $error;
+        }
+        break;
+    }
+
+    return $errors;
+  }
+
 
 }