From fa47c26907200f94f3a9904f179e14746f8ab8a0 Mon Sep 17 00:00:00 2001 From: lkassianik Date: Mon, 12 Jan 2015 13:47:15 -0800 Subject: [PATCH] T6917, PhabricatorApplicationTransactionNoEffectException when saving "blocking tasks" without changing them Summary: Fixes T6917, swallow exception when saving blocking tasks with no changes Test Plan: Open task, "Edit Blocking Tasks", save without changing, dialog should close with no exception Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6917 Differential Revision: https://secure.phabricator.com/D11353 --- .../search/controller/PhabricatorSearchAttachController.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/applications/search/controller/PhabricatorSearchAttachController.php b/src/applications/search/controller/PhabricatorSearchAttachController.php index 493a417053..890831ac71 100644 --- a/src/applications/search/controller/PhabricatorSearchAttachController.php +++ b/src/applications/search/controller/PhabricatorSearchAttachController.php @@ -74,7 +74,8 @@ final class PhabricatorSearchAttachController $txn_editor = $object->getApplicationTransactionEditor() ->setActor($user) ->setContentSourceFromRequest($request) - ->setContinueOnMissingFields(true); + ->setContinueOnMissingFields(true) + ->setContinueOnNoEffect(true); $txn_template = $object->getApplicationTransactionTemplate() ->setTransactionType(PhabricatorTransactions::TYPE_EDGE)