revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-03 11:21:01 +01:00
Code Issues Releases Wiki Activity

fix inline comment for new differential fluid view

Browse source 
Summary: we need to render left and right* classes as appropriate, plus colspan for the right

Test Plan: made inline comments and it was no longer borked

Reviewers: vrana, epriestley, chad

Reviewed By: chad

CC: aran, Korvin

Maniphest Tasks: T2005

Differential Revision: https://secure.phabricator.com/D4131
This commit is contained in:
Bob Trahan 2012-12-08 16:50:44 -08:00
parent 640a879438
commit fb1a6575dc
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/applications/differential/view/DifferentialInlineCommentEditView.php
View file

@ -65,9 +65,17 @@ final class DifferentialInlineCommentEditView extends AphrontView {
$this->renderBody()); $this->renderBody());
if ($this->onRight) { if ($this->onRight) {
$core = '<th></th><td></td><th></th><td colspan="2">'.$content.'</td>'; $core =
'<th></th>'.
'<td class="left"></td>'.
'<th></th>'.
'<td colspan="3" class="right3">'.$content.'</td>';
} else { } else {
$core = '<th></th><td>'.$content.'</td><th></th><td colspan="2"></td>'; $core =
'<th></th>'.
'<td class="left">'.$content.'</td>'.
'<th></th>'.
'<td colspan="3" class="right3"></td>';
} }
return '<table><tr class="inline-comment-splint">'.$core.'</tr></table>'; return '<table><tr class="inline-comment-splint">'.$core.'</tr></table>';