revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-20 12:30:56 +01:00
Code Issues Releases Wiki Activity

(PhabricatorIRCProtocolAdapter.connect) Use recommended connection registration order from RFC{1459,2812}

Browse source 
http://tools.ietf.org/html/rfc1459.html#section-4.1 and http://tools.ietf.org/html/rfc2812#section-3.1
 mentions that client should send the PASS first, then the latter of NICK/USER.

This is tested and confirmed working with ngircd commit 485d0aec813db9966922f17aae044df2d82b0b67

See: <https://github.com/facebook/phabricator/pull/524>

Reviewed by: epriestley
This commit is contained in:
Roy Sindre Norangshol 2014-03-04 20:06:56 +01:00 committed by epriestley
parent d1e64e64ff
commit fb87d0f491
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php
View file

@ -49,11 +49,11 @@ final class PhabricatorIRCProtocolAdapter
} }
$this->socket = $socket; $this->socket = $socket;
$this->write("USER {$user} 0 * :{$user}");
if ($pass) { if ($pass) {
$this->write("PASS {$pass}"); $this->write("PASS {$pass}");
} }
$this->write("NICK {$nick}"); $this->write("NICK {$nick}");
$this->write("USER {$user} 0 * :{$user}");
} }
public function getNextMessages($poll_frequency) { public function getNextMessages($poll_frequency) {