From fbd365d57114d2edd410b09ac42fe1343e9a6bd6 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 19 Oct 2015 13:27:47 -0700 Subject: [PATCH] Remove scattered links to "Support" document Summary: I'm going to do some version of D13941. Clean up extra links to the old document first. These were just randomly links from various places that we no longer really want feedback on and/or are now better covered by other documents. Test Plan: - `grep` - Reviewed Config/Welcome screen. - Reviewed `uri.allowed-editor-protocols`. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D14303 --- .../PhabricatorConfigWelcomeController.php | 14 ++------------ .../option/PhabricatorSecurityConfigOptions.php | 9 ++------- src/docs/user/userguide/arcanist.diviner | 5 ----- src/docs/user/userguide/audit.diviner | 6 +----- src/docs/user/userguide/differential.diviner | 3 +-- src/docs/user/userguide/phame.diviner | 8 ++------ src/docs/user/userguide/phriction.diviner | 6 ++---- 7 files changed, 10 insertions(+), 41 deletions(-) diff --git a/src/applications/config/controller/PhabricatorConfigWelcomeController.php b/src/applications/config/controller/PhabricatorConfigWelcomeController.php index 37442c2375..a3ef29bbc8 100644 --- a/src/applications/config/controller/PhabricatorConfigWelcomeController.php +++ b/src/applications/config/controller/PhabricatorConfigWelcomeController.php @@ -225,18 +225,8 @@ final class PhabricatorConfigWelcomeController 'fa-globe', $content); - $support_href = PhabricatorEnv::getDoclink('Give Feedback! Get Support!'); - $content = pht( - "=== Need Help with Setup? ===\n\n". - 'Having trouble getting something set up? See '. - '**[[ %s | Give Feedback! Get Support! ]]** for ways to get in touch '. - 'to get answers to questions, report bugs, and request features.', - $support_href); - - $explore[] = $this->newItem( - $request, - 'fa-life-ring', - $content); + // TODO: Restore some sort of "Support" link here, but just nuke it for + // now as we figure stuff out. $differential_uri = PhabricatorEnv::getURI('/differential/'); $differential_create_uri = PhabricatorEnv::getURI( diff --git a/src/applications/config/option/PhabricatorSecurityConfigOptions.php b/src/applications/config/option/PhabricatorSecurityConfigOptions.php index b8ff3ccc48..8baea2e664 100644 --- a/src/applications/config/option/PhabricatorSecurityConfigOptions.php +++ b/src/applications/config/option/PhabricatorSecurityConfigOptions.php @@ -20,8 +20,6 @@ final class PhabricatorSecurityConfigOptions } public function getOptions() { - $support_href = PhabricatorEnv::getDoclink('Give Feedback! Get Support!'); - $doc_href = PhabricatorEnv::getDoclink('Configuring a File Domain'); $doc_name = pht('Configuration Guide: Configuring a File Domain'); @@ -197,11 +195,8 @@ final class PhabricatorSecurityConfigOptions ->setSummary(pht('Whitelists editor protocols for "Open in Editor".')) ->setDescription( pht( - "Users can configure a URI pattern to open files in a text ". - "editor. The URI must use a protocol on this whitelist.\n\n". - "(If you use an editor which defines a protocol not on this ". - "list, [[ %s | let us know ]] and we'll update the defaults.)", - $support_href)) + 'Users can configure a URI pattern to open files in a text '. + 'editor. The URI must use a protocol on this whitelist.')) ->setLocked(true), $this->newOption( 'celerity.resource-hash', diff --git a/src/docs/user/userguide/arcanist.diviner b/src/docs/user/userguide/arcanist.diviner index 41613db968..f1c4545956 100644 --- a/src/docs/user/userguide/arcanist.diviner +++ b/src/docs/user/userguide/arcanist.diviner @@ -129,11 +129,6 @@ able to use: - Another common approach is to write an install script as an action into existing build scripts, so users can run `make install-arc` or `ant install-arc` or similar. - - In general, if this sucks and is causing you pain, let us know (see - @{article:Give Feedback! Get Support!}). We're planning to improve this at - some point, but it's somewhat complicated to get right. While it can take a - little time to set up, we aren't getting feedback that it's a persistent - pain point, so it hasn't been a priority. == Installing Tab Completion == diff --git a/src/docs/user/userguide/audit.diviner b/src/docs/user/userguide/audit.diviner index cff9b73e1b..9c2f752b08 100644 --- a/src/docs/user/userguide/audit.diviner +++ b/src/docs/user/userguide/audit.diviner @@ -12,9 +12,6 @@ Phabricator supports two code review workflows, "review" (pre-push) and This document summarizes the post-push "audit" workflow implemented by the creatively-named //Audit// tool. -NOTE: The audit workflow is new, give us feedback about it! See -@{article:Give Feedback! Get Support!}. - = How Audit Works = Using auditing allows you to push and deploy code without waiting for code @@ -104,5 +101,4 @@ only changes that are relevant to them. = Next Steps = - - Learn more about Herald at @{article:Herald User Guide}; or - - give us feedback at @{article:Give Feedback! Get Support!}. + - Learn more about Herald at @{article:Herald User Guide}. diff --git a/src/docs/user/userguide/differential.diviner b/src/docs/user/userguide/differential.diviner index 92f93a3015..edf992f720 100644 --- a/src/docs/user/userguide/differential.diviner +++ b/src/docs/user/userguide/differential.diviner @@ -65,5 +65,4 @@ files affected, etc.) - learn about handling large changesets at @{article:Differential User Guide: Large Changes}; or - learn about test plans at @{article:Differential User Guide: Test Plans}; or - - learn more about Herald at @{article:Herald User Guide}; or - - give us feedback at @{article:Give Feedback! Get Support!}. + - learn more about Herald at @{article:Herald User Guide}. diff --git a/src/docs/user/userguide/phame.diviner b/src/docs/user/userguide/phame.diviner index 83cd91f2cf..0de225c49f 100644 --- a/src/docs/user/userguide/phame.diviner +++ b/src/docs/user/userguide/phame.diviner @@ -5,6 +5,8 @@ Journal about your thoughts and feelings. Share with others. Profit. = Overview = +IMPORTANT: Phame is a prototype application. + Phame is a simple blogging platform. You can write drafts which only you can see. Later, you can publish these drafts as posts which anyone who can access the Phabricator instance can see. You can also add posts to blogs to increase @@ -55,9 +57,3 @@ this functionality. A given comment widget is tied 1:1 with a given post. This means the same instance of a given comment widget will appear for a given post regardless of whether that post is being viewed in the context of a blog. - -= Next Steps = - - - Phame is extremely new and very basic for now. Give us feedback on - what you'd like to see improve! See @{article:Give Feedback! Get - Support!}. diff --git a/src/docs/user/userguide/phriction.diviner b/src/docs/user/userguide/phriction.diviner index f3eaa4dffb..60ad6357fe 100644 --- a/src/docs/user/userguide/phriction.diviner +++ b/src/docs/user/userguide/phriction.diviner @@ -3,10 +3,8 @@ Construct a detailed written history of your civilization. -= Overview = +Overview +======== Phriction is a simple wiki. You can edit pages, and the text you write will stay there. Other people can see it later. - -NOTE: Phriction is extremely new and very basic for now. Give us feedback on -what you'd like to see improve! See @{article:Give Feedback! Get Support!}.