revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Convert "Page Size" field in Maniphest Advanced Search to PhabricatorSearchIntField

Browse source 
Summary:
Convert the "Page Size" field from PhabricatorSearchTextField to PhabricatorSearchIntField as its input should be an integer value (the number of tasks to display in the query results).

Closes T15723

Test Plan:
* Go to `/maniphest/query/advanced/`
* enter random values in the `Page Size` field and run random Maniphest queries (example values:  `13`, `0`, `-13`, `foobar`, `foo13bar`, `-foo1313`, `13.5`, `-13.5`, `13,5`, `-13,5`, `-`, `-0`).

Reviewers: O1 Blessed Committers, 20after4

Reviewed By: O1 Blessed Committers, 20after4

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15723

Differential Revision: https://we.phorge.it/D25527
This commit is contained in:
Andre Klapper 2024-05-01 19:37:58 +02:00
parent 74e28bc2a7
commit fbe07fbeef
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/maniphest/query/ManiphestTaskSearchEngine.php
View file

@ -141,7 +141,7 @@ final class ManiphestTaskSearchEngine
->setKey('closerPHIDs') ->setKey('closerPHIDs')
->setAliases(array('closer', 'closerPHID', 'closers')) ->setAliases(array('closer', 'closerPHID', 'closers'))
->setDescription(pht('Search for tasks closed by certain users.')), ->setDescription(pht('Search for tasks closed by certain users.')),
id(new PhabricatorSearchTextField()) id(new PhabricatorSearchIntField())
->setLabel(pht('Page Size')) ->setLabel(pht('Page Size'))
->setKey('limit'), ->setKey('limit'),
); );