1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00

Update menu item names for Applications -> Favorites

Summary: Adds a `MenuName` method to applications that `ProfileMenuItem` uses instead of the application name if set. This improves the home/menu/new user experience at little cost. Also renamed the label from Applications to Favorites, since this menu gets altered to provide more than just applications. This also allows instances to set back to Maniphest if they so choose. Overall I think this direction resolves 95% of my concerns, with maybe a small potential downside which I don't really anticipate. We already name Dashboard panels by their object, and that hasn't really caused confusion. I think these links are similar. I click 'Tasks' and get presented a list of my tasks from Maniphest.

Test Plan: Review each of the name changes as a default new install and a modified install.

Reviewers: epriestley, amckinley

Reviewed By: epriestley

Spies: Korvin

Differential Revision: https://secure.phabricator.com/D18524
This commit is contained in:
Chad Little 2017-09-04 09:20:10 -07:00
parent e1fd74ddb5
commit fc893658b8
9 changed files with 33 additions and 5 deletions

View file

@ -57,6 +57,10 @@ abstract class PhabricatorApplication
abstract public function getName();
public function getMenuName() {
return $this->getName();
}
public function getShortDescription() {
return pht('%s Application', $this->getName());
}

View file

@ -10,8 +10,12 @@ final class PhabricatorDifferentialApplication extends PhabricatorApplication {
return pht('Differential');
}
public function getMenuName() {
return pht('Code Review');
}
public function getShortDescription() {
return pht('Review Code');
return pht('Pre-Commit Review');
}
public function getIcon() {

View file

@ -6,6 +6,10 @@ final class PhabricatorDiffusionApplication extends PhabricatorApplication {
return pht('Diffusion');
}
public function getMenuName() {
return pht('Repositories');
}
public function getShortDescription() {
return pht('Host and Browse Repositories');
}

View file

@ -49,7 +49,7 @@ final class PhabricatorHomeProfileMenuEngine
$items[] = $this->newItem()
->setBuiltinKey(PhabricatorHomeConstants::ITEM_APPS_LABEL)
->setMenuItemKey(PhabricatorLabelProfileMenuItem::MENUITEMKEY)
->setMenuItemProperties(array('name' => pht('Applications')));
->setMenuItemProperties(array('name' => pht('Favorites')));
foreach ($applications as $application) {
if (!$application->isPinnedByDefault($viewer)) {

View file

@ -6,6 +6,10 @@ final class PhabricatorManiphestApplication extends PhabricatorApplication {
return pht('Maniphest');
}
public function getMenuName() {
return pht('Tasks');
}
public function getShortDescription() {
return pht('Tasks and Bugs');
}

View file

@ -6,6 +6,10 @@ final class PhabricatorPhameApplication extends PhabricatorApplication {
return pht('Phame');
}
public function getMenuName() {
return pht('Blogs');
}
public function getBaseURI() {
return '/phame/';
}
@ -15,7 +19,7 @@ final class PhabricatorPhameApplication extends PhabricatorApplication {
}
public function getShortDescription() {
return pht('Blog');
return pht('Internal and External Blogs');
}
public function getTitleGlyph() {

View file

@ -6,6 +6,10 @@ final class PhabricatorPholioApplication extends PhabricatorApplication {
return pht('Pholio');
}
public function getMenuName() {
return pht('Design Review');
}
public function getBaseURI() {
return '/pholio/';
}

View file

@ -6,10 +6,14 @@ final class PhabricatorPhrictionApplication extends PhabricatorApplication {
return pht('Phriction');
}
public function getShortDescription() {
public function getMenuName() {
return pht('Wiki');
}
public function getShortDescription() {
return pht('Wiki Documents');
}
public function getBaseURI() {
return '/w/';
}

View file

@ -31,7 +31,7 @@ final class PhabricatorApplicationProfileMenuItem
return $name;
}
return $application->getName();
return $application->getMenuName();
}
public function buildEditEngineFields(