Move "scripts/sql/probe.php" to "bin/storage probe"

Summary: This makes it namespace/database/connection aware and a little easier to find. Also use pht() / PhutilConsole.

Test Plan: Ran `bin/storage probe`.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D6341

scripts/sql/manage_storage.php

@@ -102,6 +102,7 @@ $workflows = array(
   new PhabricatorStorageManagementDestroyWorkflow(),
   new PhabricatorStorageManagementDumpWorkflow(),
   new PhabricatorStorageManagementStatusWorkflow(),
+  new PhabricatorStorageManagementProbeWorkflow(),
   new PhabricatorStorageManagementUpgradeWorkflow(),
 );
 

scripts/sql/probe.php

@@ -1,53 +0,0 @@
-#!/usr/bin/env php
-<?php
-
-$root = dirname(dirname(dirname(__FILE__)));
-require_once $root.'/scripts/__init_script__.php';
-
-$data = array();
-
-$conn_r = id(new PhabricatorUser())->establishConnection('r');
-$databases = queryfx_all($conn_r, 'SHOW DATABASES');
-foreach ($databases as $database) {
-  $name = head($database);
-  queryfx($conn_r, 'USE %C', $name);
-  $tables = queryfx_all(
-    $conn_r,
-    'SHOW TABLE STATUS');
-  $tables = ipull($tables, null, 'Name');
-  $data[$name] = $tables;
-}
-
-$totals = array_fill_keys(array_keys($data), 0);
-$overall = 0;
-
-foreach ($data as $db => $tables) {
-  foreach ($tables as $table => $info) {
-    $table_size = $info['Data_length'] + $info['Index_length'];
-
-    $data[$db][$table]['_totalSize'] = $table_size;
-    $totals[$db] += $table_size;
-    $overall += $table_size;
-  }
-}
-
-echo "APPROXIMATE TABLE SIZES\n";
-asort($totals);
-foreach ($totals as $db => $size) {
-  printf("%-32.32s %18s\n", $db, fmt($totals[$db], $overall));
-  $data[$db] = isort($data[$db], '_totalSize');
-  foreach ($data[$db] as $table => $info) {
-    printf("    %-28.28s %18s\n", $table, fmt($info['_totalSize'], $overall));
-  }
-}
-printf("%-32.32s %18s\n", 'TOTAL', fmt($overall, $overall));
-
-function fmt($n, $o) {
-
-  return sprintf(
-    '%8.8s MB  %5.5s%%',
-    number_format($n / (1024 * 1024), 1),
-    sprintf('%3.1f', 100 * ($n / $o)));
-}
-
-

src/__phutil_library_map__.php

@@ -1514,6 +1514,7 @@ phutil_register_library_map(array(
     'PhabricatorStorageManagementDatabasesWorkflow' => 'infrastructure/storage/management/workflow/PhabricatorStorageManagementDatabasesWorkflow.php',
     'PhabricatorStorageManagementDestroyWorkflow' => 'infrastructure/storage/management/workflow/PhabricatorStorageManagementDestroyWorkflow.php',
     'PhabricatorStorageManagementDumpWorkflow' => 'infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php',
+    'PhabricatorStorageManagementProbeWorkflow' => 'infrastructure/storage/management/workflow/PhabricatorStorageManagementProbeWorkflow.php',
     'PhabricatorStorageManagementStatusWorkflow' => 'infrastructure/storage/management/workflow/PhabricatorStorageManagementStatusWorkflow.php',
     'PhabricatorStorageManagementUpgradeWorkflow' => 'infrastructure/storage/management/workflow/PhabricatorStorageManagementUpgradeWorkflow.php',
     'PhabricatorStorageManagementWorkflow' => 'infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php',
@@ -3418,6 +3419,7 @@ phutil_register_library_map(array(
     'PhabricatorStorageManagementDatabasesWorkflow' => 'PhabricatorStorageManagementWorkflow',
     'PhabricatorStorageManagementDestroyWorkflow' => 'PhabricatorStorageManagementWorkflow',
     'PhabricatorStorageManagementDumpWorkflow' => 'PhabricatorStorageManagementWorkflow',
+    'PhabricatorStorageManagementProbeWorkflow' => 'PhabricatorStorageManagementWorkflow',
     'PhabricatorStorageManagementStatusWorkflow' => 'PhabricatorStorageManagementWorkflow',
     'PhabricatorStorageManagementUpgradeWorkflow' => 'PhabricatorStorageManagementWorkflow',
     'PhabricatorStorageManagementWorkflow' => 'PhutilArgumentWorkflow',

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementProbeWorkflow.php

@@ -0,0 +1,78 @@
+<?php
+
+final class PhabricatorStorageManagementProbeWorkflow
+  extends PhabricatorStorageManagementWorkflow {
+
+  public function didConstruct() {
+    $this
+      ->setName('probe')
+      ->setExamples('**probe**')
+      ->setSynopsis('Show approximate table sizes.');
+  }
+
+  public function execute(PhutilArgumentParser $args) {
+    $console = PhutilConsole::getConsole();
+    $console->writeErr(
+      "%s\n",
+      pht("Analyzing table sizes (this may take a moment)..."));
+
+    $api = $this->getAPI();
+    $patches = $this->getPatches();
+    $databases = $api->getDatabaseList($patches);
+
+    $conn_r = $api->getConn(null);
+
+    $data = array();
+    foreach ($databases as $database) {
+      queryfx($conn_r, 'USE %C', $database);
+      $tables = queryfx_all(
+        $conn_r,
+        'SHOW TABLE STATUS');
+      $tables = ipull($tables, null, 'Name');
+      $data[$database] = $tables;
+    }
+
+    $totals = array_fill_keys(array_keys($data), 0);
+    $overall = 0;
+
+    foreach ($data as $db => $tables) {
+      foreach ($tables as $table => $info) {
+        $table_size = $info['Data_length'] + $info['Index_length'];
+
+        $data[$db][$table]['_totalSize'] = $table_size;
+        $totals[$db] += $table_size;
+        $overall += $table_size;
+      }
+    }
+
+    $console->writeOut("%s\n", pht("APPROXIMATE TABLE SIZES"));
+    asort($totals);
+    foreach ($totals as $db => $size) {
+      $database_size = $this->formatSize($totals[$db], $overall);
+      $console->writeOut(
+        "**%s**\n",
+        sprintf("%-32.32s %18s", $db, $database_size));
+      $data[$db] = isort($data[$db], '_totalSize');
+      foreach ($data[$db] as $table => $info) {
+        $table_size = $this->formatSize($info['_totalSize'], $overall);
+        $console->writeOut(
+          "%s\n",
+          sprintf("    %-28.28s %18s", $table, $table_size));
+      }
+    }
+    $overall_size = $this->formatSize($overall, $overall);
+    $console->writeOut(
+      "**%s**\n",
+      sprintf("%-32.32s %18s", pht('TOTAL'), $overall_size));
+
+    return 0;
+  }
+
+  private function formatSize($n, $o) {
+    return sprintf(
+      '%8.8s MB  %5.5s%%',
+      number_format($n / (1024 * 1024), 1),
+      sprintf('%3.1f', 100 * ($n / $o)));
+  }
+
+}