fix differential + diffusion for showing generated files

Summary: in the re-factor quest this got broken. Turns out NewLines (aka $this->new in the parser) gets updated right up until the very end for showing text changes so instead pass over the total line count to the renderer to get this codepath right.

Test Plan: showed content of some generated files in diffusion and all was well

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2204

Differential Revision: https://secure.phabricator.com/D4237

src/applications/differential/parser/DifferentialChangesetParser.php

@@ -972,9 +972,14 @@ final class DifferentialChangesetParser {
     $this->tryCacheStuff();
     $render_pch = $this->shouldRenderPropertyChangeHeader($this->changeset);
 
+    $rows = max(
+      count($this->old),
+      count($this->new));
+
     $renderer = id(new DifferentialChangesetTwoUpRenderer())
       ->setChangeset($this->changeset)
       ->setRenderPropertyChangeHeader($render_pch)
+      ->setLineCount($rows)
       ->setOldRender($this->oldRender)
       ->setNewRender($this->newRender)
       ->setMissingOldLines($this->missingOld)
@@ -1156,9 +1161,6 @@ final class DifferentialChangesetParser {
       ->setOriginalOld($this->originalLeft)
       ->setOriginalNew($this->originalRight);
 
-    $rows = max(
-      count($this->old),
-      count($this->new));
     if ($range_start === null) {
       $range_start = 0;
     }

src/applications/differential/render/DifferentialChangesetRenderer.php

@@ -28,6 +28,15 @@ abstract class DifferentialChangesetRenderer {
   private $gaps;
   private $mask;
   private $depths;
+  private $lineCount;
+
+  public function setLineCount($line_count) {
+    $this->lineCount = $line_count;
+    return $this;
+  }
+  public function getLineCount() {
+    return $this->lineCount;
+  }
 
   public function setDepths($depths) {
     $this->depths = $depths;
@@ -260,10 +269,7 @@ abstract class DifferentialChangesetRenderer {
   public function renderShield($message, $more) {
 
     if ($more) {
-      $end = max(
+      $end = $this->getLineCount();
-        count($this->getOldLines()),
-        count($this->getNewLines())
-      );
       $reference = $this->getRenderingReference();
       $more =
         ' '.