Replace "getRequestURI()->setQueryParams(array())" with "getPath()"

Summary:
Ref T13250. A handful of callsites are doing `getRequestURI()` + `setQueryParams(array())` to get a bare request path.

They can just use `getPath()` instead.

Test Plan: See inlines.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13250

Differential Revision: https://secure.phabricator.com/D20150

src/aphront/response/AphrontAjaxResponse.php

@@ -32,22 +32,21 @@ final class AphrontAjaxResponse extends AphrontResponse {
   }
 
   public function buildResponseString() {
+    $request = $this->getRequest();
     $console = $this->getConsole();
     if ($console) {
       // NOTE: We're stripping query parameters here both for readability and
       // to mitigate BREACH and similar attacks. The parameters are available
       // in the "Request" tab, so this should not impact usability. See T3684.
-      $uri = $this->getRequest()->getRequestURI();
+      $path = $request->getPath();
-      $uri = new PhutilURI($uri);
-      $uri->setQueryParams(array());
 
       Javelin::initBehavior(
         'dark-console',
         array(
-          'uri'       => (string)$uri,
+          'uri'       => $path,
-          'key'       => $console->getKey($this->getRequest()),
+          'key'       => $console->getKey($request),
           'color'     => $console->getColor(),
-          'quicksand' => $this->getRequest()->isQuicksand(),
+          'quicksand' => $request->isQuicksand(),
         ));
     }
 
@@ -60,7 +59,6 @@ final class AphrontAjaxResponse extends AphrontResponse {
 
     $response = CelerityAPI::getStaticResourceResponse();
 
-    $request = $this->getRequest();
     if ($request) {
       $viewer = $request->getViewer();
       if ($viewer) {

src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php

@@ -11,8 +11,7 @@ final class PhabricatorChatLogChannelLogController
     $viewer = $request->getViewer();
     $id = $request->getURIData('channelID');
 
-    $uri = clone $request->getRequestURI();
+    $uri = new PhutilURI($request->getPath());
-    $uri->setQueryParams(array());
 
     $pager = new AphrontCursorPagerView();
     $pager->setURI($uri);

src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php

@@ -54,8 +54,7 @@ final class PhabricatorMetaMTAApplicationEmailPanel
       return new Aphront404Response();
     }
 
-    $uri = $request->getRequestURI();
+    $uri = new PhutilURI($request->getPath());
-    $uri->setQueryParams(array());
 
     $new = $request->getStr('new');
     $edit = $request->getInt('edit');

src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php

@@ -31,8 +31,7 @@ final class PhabricatorEmailAddressesSettingsPanel
     $user = $this->getUser();
     $editable = PhabricatorEnv::getEnvConfig('account.editable');
 
-    $uri = $request->getRequestURI();
+    $uri = new PhutilURI($request->getPath());
-    $uri->setQueryParams(array());
 
     if ($editable) {
       $new = $request->getStr('new');

src/applications/transactions/editengine/PhabricatorEditEngine.php

@@ -1279,8 +1279,7 @@ abstract class PhabricatorEditEngine
 
     $fields = $this->willBuildEditForm($object, $fields);
 
-    $request_path = $request->getRequestURI()
+    $request_path = $request->getPath();
-      ->setQueryParams(array());
 
     $form = id(new AphrontFormView())
       ->setUser($viewer)