mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-23 05:50:55 +01:00
Hide the "Author" field in Differential on the web create workflow
Summary: Ref T13628. When creating a revision, hide the recently introduced "Author" field. It seems exceedingly unlikely that anyone would ever want to adjust this field when creating a revision, and this workflow already has a lot of fields and complexity, so this likely adds more noise than signal on the balance. Test Plan: - Created revisions via copy/paste on the web workflow, no longer saw "Author". - Used "Edit Revision" to adjust the author normally. Maniphest Tasks: T13628 Differential Revision: https://secure.phabricator.com/D21595
This commit is contained in:
parent
a9704428ff
commit
fceb9a3f9e
1 changed files with 9 additions and 0 deletions
|
@ -187,6 +187,15 @@ final class DifferentialRevisionEditEngine
|
|||
->setConduitTypeDescription(pht('New author.'))
|
||||
->setSingleValue($object->getAuthorPHID());
|
||||
|
||||
// Don't show the "Author" field when creating a revision using the web
|
||||
// workflow, since it adds more noise than signal to this workflow.
|
||||
if ($this->getIsCreate()) {
|
||||
$author_field->setIsHidden(true);
|
||||
}
|
||||
|
||||
// Only show the "Foist Upon" comment action to the current revision
|
||||
// author. Other users can use "Edit Revision", it's just very unlikley
|
||||
// that they're interested in this action.
|
||||
if ($viewer->getPHID() === $object->getAuthorPHID()) {
|
||||
$author_field->setCommentActionLabel(pht('Foist Upon'));
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue