From fd0591e168802ee6178307101376166c10452542 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 3 Feb 2017 06:12:51 -0800 Subject: [PATCH] Restore "Auditor" as an alias for the commit message field "Auditors" Summary: Fixes T12197. I //think// this field was never recognized by Differential (it doesn't appear in D17070, but maybe that isn't the right change). It was recognized by the ad-hoc regular expression which I replaced with a formal parser in D17262. Allow the former parser to accept "Auditor" as an alias for "Auditors". Test Plan: Committed a change with `Auditor: dog`, saw the audit trigger correctly in the web UI. Reviewers: chad Reviewed By: chad Maniphest Tasks: T12197 Differential Revision: https://secure.phabricator.com/D17306 --- .../field/DifferentialAuditorsCommitMessageField.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/applications/differential/field/DifferentialAuditorsCommitMessageField.php b/src/applications/differential/field/DifferentialAuditorsCommitMessageField.php index 42e6b5ecd5..bd4d9f3009 100644 --- a/src/applications/differential/field/DifferentialAuditorsCommitMessageField.php +++ b/src/applications/differential/field/DifferentialAuditorsCommitMessageField.php @@ -9,6 +9,12 @@ final class DifferentialAuditorsCommitMessageField return pht('Auditors'); } + public function getFieldAliases() { + return array( + 'Auditor', + ); + } + public function parseFieldValue($value) { return $this->parseObjectList( $value,