From fd084e39573d503243767d968464a7ff934ee4f9 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Fri, 31 May 2013 07:17:52 -0700 Subject: [PATCH] Let mobile dialogs go full width Summary: We were clipping this to 300px, which is arbitrary to iPhone. Test Plan: test on Nexus, iPhone Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6089 --- src/__celerity_resource_map__.php | 92 ++++++++++++------------ webroot/rsrc/css/aphront/dialog-view.css | 4 -- 2 files changed, 46 insertions(+), 50 deletions(-) diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php index 00569443a6..ed5d0740f5 100644 --- a/src/__celerity_resource_map__.php +++ b/src/__celerity_resource_map__.php @@ -782,7 +782,7 @@ celerity_register_resource_map(array( ), 'aphront-dialog-view-css' => array( - 'uri' => '/res/75663cde/rsrc/css/aphront/dialog-view.css', + 'uri' => '/res/71190d8c/rsrc/css/aphront/dialog-view.css', 'type' => 'css', 'requires' => array( @@ -3988,7 +3988,7 @@ celerity_register_resource_map(array( ), array( 'packages' => array( - '1b14560c' => + 'a94fc53b' => array( 'name' => 'core.pkg.css', 'symbols' => @@ -4037,7 +4037,7 @@ celerity_register_resource_map(array( 41 => 'phabricator-property-list-view-css', 42 => 'phabricator-tag-view-css', ), - 'uri' => '/res/pkg/1b14560c/core.pkg.css', + 'uri' => '/res/pkg/a94fc53b/core.pkg.css', 'type' => 'css', ), '98f60e3f' => @@ -4231,16 +4231,16 @@ celerity_register_resource_map(array( 'reverse' => array( 'aphront-attached-file-view-css' => '6b1fccc6', - 'aphront-dialog-view-css' => '1b14560c', - 'aphront-error-view-css' => '1b14560c', - 'aphront-form-view-css' => '1b14560c', - 'aphront-list-filter-view-css' => '1b14560c', - 'aphront-pager-view-css' => '1b14560c', - 'aphront-panel-view-css' => '1b14560c', - 'aphront-table-view-css' => '1b14560c', - 'aphront-tokenizer-control-css' => '1b14560c', - 'aphront-tooltip-css' => '1b14560c', - 'aphront-typeahead-control-css' => '1b14560c', + 'aphront-dialog-view-css' => 'a94fc53b', + 'aphront-error-view-css' => 'a94fc53b', + 'aphront-form-view-css' => 'a94fc53b', + 'aphront-list-filter-view-css' => 'a94fc53b', + 'aphront-pager-view-css' => 'a94fc53b', + 'aphront-panel-view-css' => 'a94fc53b', + 'aphront-table-view-css' => 'a94fc53b', + 'aphront-tokenizer-control-css' => 'a94fc53b', + 'aphront-tooltip-css' => 'a94fc53b', + 'aphront-typeahead-control-css' => 'a94fc53b', 'differential-changeset-view-css' => 'dd27a69b', 'differential-core-view-css' => 'dd27a69b', 'differential-inline-comment-editor' => '9488bb69', @@ -4254,7 +4254,7 @@ celerity_register_resource_map(array( 'differential-table-of-contents-css' => 'dd27a69b', 'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88', - 'global-drag-and-drop-css' => '1b14560c', + 'global-drag-and-drop-css' => 'a94fc53b', 'inline-comment-summary-css' => 'dd27a69b', 'javelin-aphlict' => '98f60e3f', 'javelin-behavior' => 'a9f14d76', @@ -4328,56 +4328,56 @@ celerity_register_resource_map(array( 'javelin-util' => 'a9f14d76', 'javelin-vector' => 'a9f14d76', 'javelin-workflow' => 'a9f14d76', - 'lightbox-attachment-css' => '1b14560c', + 'lightbox-attachment-css' => 'a94fc53b', 'maniphest-task-summary-css' => '6b1fccc6', 'maniphest-transaction-detail-css' => '6b1fccc6', - 'phabricator-action-list-view-css' => '1b14560c', - 'phabricator-application-launch-view-css' => '1b14560c', + 'phabricator-action-list-view-css' => 'a94fc53b', + 'phabricator-application-launch-view-css' => 'a94fc53b', 'phabricator-busy' => '98f60e3f', 'phabricator-content-source-view-css' => 'dd27a69b', - 'phabricator-core-buttons-css' => '1b14560c', - 'phabricator-core-css' => '1b14560c', - 'phabricator-crumbs-view-css' => '1b14560c', - 'phabricator-directory-css' => '1b14560c', + 'phabricator-core-buttons-css' => 'a94fc53b', + 'phabricator-core-css' => 'a94fc53b', + 'phabricator-crumbs-view-css' => 'a94fc53b', + 'phabricator-directory-css' => 'a94fc53b', 'phabricator-drag-and-drop-file-upload' => '9488bb69', 'phabricator-dropdown-menu' => '98f60e3f', 'phabricator-file-upload' => '98f60e3f', - 'phabricator-filetree-view-css' => '1b14560c', - 'phabricator-flag-css' => '1b14560c', - 'phabricator-form-view-css' => '1b14560c', - 'phabricator-header-view-css' => '1b14560c', + 'phabricator-filetree-view-css' => 'a94fc53b', + 'phabricator-flag-css' => 'a94fc53b', + 'phabricator-form-view-css' => 'a94fc53b', + 'phabricator-header-view-css' => 'a94fc53b', 'phabricator-hovercard' => '98f60e3f', - 'phabricator-jump-nav' => '1b14560c', + 'phabricator-jump-nav' => 'a94fc53b', 'phabricator-keyboard-shortcut' => '98f60e3f', 'phabricator-keyboard-shortcut-manager' => '98f60e3f', - 'phabricator-main-menu-view' => '1b14560c', + 'phabricator-main-menu-view' => 'a94fc53b', 'phabricator-menu-item' => '98f60e3f', - 'phabricator-nav-view-css' => '1b14560c', + 'phabricator-nav-view-css' => 'a94fc53b', 'phabricator-notification' => '98f60e3f', - 'phabricator-notification-css' => '1b14560c', - 'phabricator-notification-menu-css' => '1b14560c', - 'phabricator-object-item-list-view-css' => '1b14560c', + 'phabricator-notification-css' => 'a94fc53b', + 'phabricator-notification-menu-css' => 'a94fc53b', + 'phabricator-object-item-list-view-css' => 'a94fc53b', 'phabricator-object-selector-css' => 'dd27a69b', 'phabricator-phtize' => '98f60e3f', 'phabricator-prefab' => '98f60e3f', 'phabricator-project-tag-css' => '6b1fccc6', - 'phabricator-property-list-view-css' => '1b14560c', - 'phabricator-remarkup-css' => '1b14560c', + 'phabricator-property-list-view-css' => 'a94fc53b', + 'phabricator-remarkup-css' => 'a94fc53b', 'phabricator-shaped-request' => '9488bb69', - 'phabricator-side-menu-view-css' => '1b14560c', - 'phabricator-standard-page-view' => '1b14560c', - 'phabricator-tag-view-css' => '1b14560c', + 'phabricator-side-menu-view-css' => 'a94fc53b', + 'phabricator-standard-page-view' => 'a94fc53b', + 'phabricator-tag-view-css' => 'a94fc53b', 'phabricator-textareautils' => '98f60e3f', 'phabricator-tooltip' => '98f60e3f', - 'phabricator-transaction-view-css' => '1b14560c', - 'phabricator-zindex-css' => '1b14560c', - 'phui-form-css' => '1b14560c', - 'phui-icon-view-css' => '1b14560c', - 'spacing-css' => '1b14560c', - 'sprite-apps-large-css' => '1b14560c', - 'sprite-gradient-css' => '1b14560c', - 'sprite-icons-css' => '1b14560c', - 'sprite-menu-css' => '1b14560c', - 'syntax-highlighting-css' => '1b14560c', + 'phabricator-transaction-view-css' => 'a94fc53b', + 'phabricator-zindex-css' => 'a94fc53b', + 'phui-form-css' => 'a94fc53b', + 'phui-icon-view-css' => 'a94fc53b', + 'spacing-css' => 'a94fc53b', + 'sprite-apps-large-css' => 'a94fc53b', + 'sprite-gradient-css' => 'a94fc53b', + 'sprite-icons-css' => 'a94fc53b', + 'sprite-menu-css' => 'a94fc53b', + 'syntax-highlighting-css' => 'a94fc53b', ), )); diff --git a/webroot/rsrc/css/aphront/dialog-view.css b/webroot/rsrc/css/aphront/dialog-view.css index 4d39748022..a2d7f62ee1 100644 --- a/webroot/rsrc/css/aphront/dialog-view.css +++ b/webroot/rsrc/css/aphront/dialog-view.css @@ -9,10 +9,6 @@ box-shadow: 0 4px 12px rgba(0,0,0,.4),inset 0 1px 0 rgba(255,255,255,.5); } -.device-phone .aphront-dialog-view { - width: 300px; -} - .aphront-dialog-head .phabricator-action-header { border-bottom: 1px solid #d4dadf; padding: 5px 15px;