1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00

Use normalsized font sizes in AphrontTable

Summary: Updates to use the standard 13px size we use everywhere else, cleans up a few mobile/display bugs, adds a hover state for `tr`.

Test Plan:
Review Diffusion, Daemons, Almanac, People Logs, anything else?

{F4991070}

{F4991071}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D18088
This commit is contained in:
Chad Little 2017-06-06 15:47:47 -07:00
parent d89c24a460
commit fd0cac0d45
3 changed files with 22 additions and 28 deletions

View file

@ -9,13 +9,13 @@ return array(
'names' => array( 'names' => array(
'conpherence.pkg.css' => 'ff161f2d', 'conpherence.pkg.css' => 'ff161f2d',
'conpherence.pkg.js' => 'b5b51108', 'conpherence.pkg.js' => 'b5b51108',
'core.pkg.css' => 'd88bfb44', 'core.pkg.css' => 'f1bbed88',
'core.pkg.js' => '1475bd91', 'core.pkg.js' => '1475bd91',
'darkconsole.pkg.js' => '1f9a31bc', 'darkconsole.pkg.js' => '1f9a31bc',
'differential.pkg.css' => '1ccbf3a9', 'differential.pkg.css' => '1ccbf3a9',
'differential.pkg.js' => '889ab0ab', 'differential.pkg.js' => '889ab0ab',
'diffusion.pkg.css' => 'b93d9b8c', 'diffusion.pkg.css' => 'b93d9b8c',
'diffusion.pkg.js' => '84c8f8fd', 'diffusion.pkg.js' => '6134c5a1',
'favicon.ico' => '30672e08', 'favicon.ico' => '30672e08',
'maniphest.pkg.css' => '4845691a', 'maniphest.pkg.css' => '4845691a',
'maniphest.pkg.js' => '5ab2753f', 'maniphest.pkg.js' => '5ab2753f',
@ -32,7 +32,7 @@ return array(
'rsrc/css/aphront/notification.css' => '3f6c89c9', 'rsrc/css/aphront/notification.css' => '3f6c89c9',
'rsrc/css/aphront/panel-view.css' => '8427b78d', 'rsrc/css/aphront/panel-view.css' => '8427b78d',
'rsrc/css/aphront/phabricator-nav-view.css' => 'faf6a6fc', 'rsrc/css/aphront/phabricator-nav-view.css' => 'faf6a6fc',
'rsrc/css/aphront/table-view.css' => '34cf86b4', 'rsrc/css/aphront/table-view.css' => 'a3aa6910',
'rsrc/css/aphront/tokenizer.css' => '15d5ff71', 'rsrc/css/aphront/tokenizer.css' => '15d5ff71',
'rsrc/css/aphront/tooltip.css' => '173b9431', 'rsrc/css/aphront/tooltip.css' => '173b9431',
'rsrc/css/aphront/typeahead-browse.css' => '4f82e510', 'rsrc/css/aphront/typeahead-browse.css' => '4f82e510',
@ -406,7 +406,7 @@ return array(
'rsrc/js/application/diffusion/DiffusionLocateFileSource.js' => 'c93358e3', 'rsrc/js/application/diffusion/DiffusionLocateFileSource.js' => 'c93358e3',
'rsrc/js/application/diffusion/behavior-audit-preview.js' => 'd835b03a', 'rsrc/js/application/diffusion/behavior-audit-preview.js' => 'd835b03a',
'rsrc/js/application/diffusion/behavior-commit-branches.js' => 'bdaf4d04', 'rsrc/js/application/diffusion/behavior-commit-branches.js' => 'bdaf4d04',
'rsrc/js/application/diffusion/behavior-commit-graph.js' => '49ae8328', 'rsrc/js/application/diffusion/behavior-commit-graph.js' => '75b83cbb',
'rsrc/js/application/diffusion/behavior-diffusion-browse-file.js' => '054a0f0b', 'rsrc/js/application/diffusion/behavior-diffusion-browse-file.js' => '054a0f0b',
'rsrc/js/application/diffusion/behavior-jump-to.js' => '73d09eef', 'rsrc/js/application/diffusion/behavior-jump-to.js' => '73d09eef',
'rsrc/js/application/diffusion/behavior-load-blame.js' => '42126667', 'rsrc/js/application/diffusion/behavior-load-blame.js' => '42126667',
@ -542,7 +542,7 @@ return array(
'aphront-list-filter-view-css' => '5d6f0526', 'aphront-list-filter-view-css' => '5d6f0526',
'aphront-multi-column-view-css' => '84cc6640', 'aphront-multi-column-view-css' => '84cc6640',
'aphront-panel-view-css' => '8427b78d', 'aphront-panel-view-css' => '8427b78d',
'aphront-table-view-css' => '34cf86b4', 'aphront-table-view-css' => 'a3aa6910',
'aphront-tokenizer-control-css' => '15d5ff71', 'aphront-tokenizer-control-css' => '15d5ff71',
'aphront-tooltip-css' => '173b9431', 'aphront-tooltip-css' => '173b9431',
'aphront-typeahead-control-css' => '8a84cc7d', 'aphront-typeahead-control-css' => '8a84cc7d',
@ -620,7 +620,7 @@ return array(
'javelin-behavior-differential-user-select' => 'a8d8459d', 'javelin-behavior-differential-user-select' => 'a8d8459d',
'javelin-behavior-diffusion-browse-file' => '054a0f0b', 'javelin-behavior-diffusion-browse-file' => '054a0f0b',
'javelin-behavior-diffusion-commit-branches' => 'bdaf4d04', 'javelin-behavior-diffusion-commit-branches' => 'bdaf4d04',
'javelin-behavior-diffusion-commit-graph' => '49ae8328', 'javelin-behavior-diffusion-commit-graph' => '75b83cbb',
'javelin-behavior-diffusion-jump-to' => '73d09eef', 'javelin-behavior-diffusion-jump-to' => '73d09eef',
'javelin-behavior-diffusion-locate-file' => '6d3e1947', 'javelin-behavior-diffusion-locate-file' => '6d3e1947',
'javelin-behavior-diffusion-pull-lastmodified' => 'f01586dc', 'javelin-behavior-diffusion-pull-lastmodified' => 'f01586dc',
@ -1224,11 +1224,6 @@ return array(
'javelin-vector', 'javelin-vector',
'javelin-stratcom', 'javelin-stratcom',
), ),
'49ae8328' => array(
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
),
'4b3c4443' => array( '4b3c4443' => array(
'phuix-icon-view', 'phuix-icon-view',
), ),
@ -1445,6 +1440,11 @@ return array(
'javelin-install', 'javelin-install',
'javelin-workboard-card', 'javelin-workboard-card',
), ),
'75b83cbb' => array(
'javelin-behavior',
'javelin-dom',
'javelin-stratcom',
),
'76b9fc3e' => array( '76b9fc3e' => array(
'javelin-behavior', 'javelin-behavior',
'javelin-stratcom', 'javelin-stratcom',

View file

@ -24,7 +24,6 @@
.aphront-table-notice { .aphront-table-notice {
padding: 12px 16px; padding: 12px 16px;
font-size: {$normalfontsize};
color: {$darkbluetext}; color: {$darkbluetext};
border-bottom: 1px solid {$thinblueborder}; border-bottom: 1px solid {$thinblueborder};
} }
@ -37,9 +36,16 @@
background: {$lightgreybackground}; background: {$lightgreybackground};
} }
.device-desktop .aphront-table-view tr:hover {
background: {$bluebackground};
}
.device-desktop .aphront-table-view tr.no-data:hover {
background: inherit;
}
.aphront-table-view th { .aphront-table-view th {
font-weight: bold; font-weight: bold;
font-size: {$normalfontsize};
white-space: nowrap; white-space: nowrap;
color: {$bluetext}; color: {$bluetext};
text-shadow: 0 1px 0 white; text-shadow: 0 1px 0 white;
@ -78,6 +84,7 @@ th.aphront-table-view-sortable-selected {
.aphront-table-view td { .aphront-table-view td {
white-space: nowrap; white-space: nowrap;
vertical-align: middle; vertical-align: middle;
color: {$darkbluetext};
} }
.aphront-table-down-sort { .aphront-table-down-sort {
@ -115,12 +122,10 @@ th.aphront-table-view-sortable-selected {
.aphront-table-view th { .aphront-table-view th {
padding: 8px 10px; padding: 8px 10px;
font-size: {$normalfontsize};
} }
.aphront-table-view td { .aphront-table-view td {
padding: 8px 10px; padding: 8px 10px;
font-size: {$smallerfontsize};
} }
.device-tablet .aphront-table-view td, .device-tablet .aphront-table-view td,
@ -128,22 +133,12 @@ th.aphront-table-view-sortable-selected {
padding: 6px; padding: 6px;
} }
.device-tablet .aphront-table-view td + td,
.device-phone .aphront-table-view td + td {
padding-left: 0px;
}
.device-tablet .aphront-table-view th, .device-tablet .aphront-table-view th,
.device-phone .aphront-table-view th { .device-phone .aphront-table-view th {
padding: 6px; padding: 6px;
overflow: hidden; overflow: hidden;
} }
.device-tablet .aphront-table-view th + th,
.device-phone .aphront-table-view th + th {
padding-left: 0px;
}
.aphront-table-view td.sorted-column { .aphront-table-view td.sorted-column {
background: {$lightbluebackground}; background: {$lightbluebackground};
} }
@ -196,7 +191,7 @@ th.aphront-table-view-sortable-selected {
} }
.aphront-table-view td.wrap { .aphront-table-view td.wrap {
white-space: normal; white-space: normal;
} }
.aphront-table-view td.prewrap { .aphront-table-view td.prewrap {
@ -282,7 +277,6 @@ span.single-display-line-content {
text-align: center; text-align: center;
color: {$lightgreytext}; color: {$lightgreytext};
font-style: italic; font-style: italic;
font-size: {$normalfontsize};
} }
.aphront-table-view td.thumb img { .aphront-table-view td.thumb img {

View file

@ -53,7 +53,7 @@ JX.behavior('diffusion-commit-graph', function(config) {
return (col * cell) + (cell / 2); return (col * cell) + (cell / 2);
}; };
var h = 32; var h = 34;
var w = cell * config.count; var w = cell * config.count;
var canvas = JX.$N('canvas', {width: w, height: h}); var canvas = JX.$N('canvas', {width: w, height: h});