From fd0da4c41f822182dc40822a498e03995c4a5485 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 28 Aug 2018 13:57:35 -0700 Subject: [PATCH] Rename "PHUIDocumentViewPro" to "PHUIDocumentView" Summary: Ref T13077. There is no "PHUIDocumentView" so toss the "Pro" suffix from this classname. Test Plan: Grepped for `PHUIDocumentView` and `PHUIDocumentViewPro`. Reviewers: amckinley Maniphest Tasks: T13077 Differential Revision: https://secure.phabricator.com/D19616 --- src/__phutil_library_map__.php | 4 ++-- .../diffusion/view/DiffusionReadmeView.php | 2 +- .../diviner/controller/DivinerAtomController.php | 2 +- .../diviner/controller/DivinerBookController.php | 2 +- .../diviner/controller/DivinerMainController.php | 2 +- .../guides/module/PhabricatorGuideInstallModule.php | 2 +- .../module/PhabricatorGuideQuickStartModule.php | 2 +- .../controller/LegalpadDocumentSignController.php | 2 +- ...habricatorApplicationEmailCommandsController.php | 2 +- .../phame/controller/PhameHomeController.php | 2 +- .../controller/blog/PhameBlogViewController.php | 2 +- .../controller/post/PhamePostViewController.php | 2 +- .../controller/PhrictionDocumentController.php | 13 +++++++------ .../editengine/PhabricatorEditEngine.php | 2 +- .../PhabricatorTypeaheadFunctionHelpController.php | 2 +- ...PHUIDocumentViewPro.php => PHUIDocumentView.php} | 2 +- src/view/phui/PHUIRemarkupPreviewPanel.php | 2 +- 17 files changed, 24 insertions(+), 23 deletions(-) rename src/view/phui/{PHUIDocumentViewPro.php => PHUIDocumentView.php} (98%) diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php index b6d71ea81b..284980bcc5 100644 --- a/src/__phutil_library_map__.php +++ b/src/__phutil_library_map__.php @@ -1912,7 +1912,7 @@ phutil_register_library_map(array( 'PHUIDiffTableOfContentsListView' => 'infrastructure/diff/view/PHUIDiffTableOfContentsListView.php', 'PHUIDiffTwoUpInlineCommentRowScaffold' => 'infrastructure/diff/view/PHUIDiffTwoUpInlineCommentRowScaffold.php', 'PHUIDocumentSummaryView' => 'view/phui/PHUIDocumentSummaryView.php', - 'PHUIDocumentViewPro' => 'view/phui/PHUIDocumentViewPro.php', + 'PHUIDocumentView' => 'view/phui/PHUIDocumentView.php', 'PHUIFeedStoryExample' => 'applications/uiexample/examples/PHUIFeedStoryExample.php', 'PHUIFeedStoryView' => 'view/phui/PHUIFeedStoryView.php', 'PHUIFormDividerControl' => 'view/form/control/PHUIFormDividerControl.php', @@ -7453,7 +7453,7 @@ phutil_register_library_map(array( 'PHUIDiffTableOfContentsListView' => 'AphrontView', 'PHUIDiffTwoUpInlineCommentRowScaffold' => 'PHUIDiffInlineCommentRowScaffold', 'PHUIDocumentSummaryView' => 'AphrontTagView', - 'PHUIDocumentViewPro' => 'AphrontTagView', + 'PHUIDocumentView' => 'AphrontTagView', 'PHUIFeedStoryExample' => 'PhabricatorUIExample', 'PHUIFeedStoryView' => 'AphrontView', 'PHUIFormDividerControl' => 'AphrontFormControl', diff --git a/src/applications/diffusion/view/DiffusionReadmeView.php b/src/applications/diffusion/view/DiffusionReadmeView.php index 693333249d..21e97f4718 100644 --- a/src/applications/diffusion/view/DiffusionReadmeView.php +++ b/src/applications/diffusion/view/DiffusionReadmeView.php @@ -94,7 +94,7 @@ final class DiffusionReadmeView extends DiffusionView { } $readme_content = phutil_tag_div($class, $readme_content); - $document = id(new PHUIDocumentViewPro()) + $document = id(new PHUIDocumentView()) ->setFluid(true) ->appendChild($readme_content); diff --git a/src/applications/diviner/controller/DivinerAtomController.php b/src/applications/diviner/controller/DivinerAtomController.php index bf69497b16..0c92bd1738 100644 --- a/src/applications/diviner/controller/DivinerAtomController.php +++ b/src/applications/diviner/controller/DivinerAtomController.php @@ -72,7 +72,7 @@ final class DivinerAtomController extends DivinerController { $prop_list = new PHUIPropertyGroupView(); $prop_list->addPropertyList($properties); - $document = id(new PHUIDocumentViewPro()) + $document = id(new PHUIDocumentView()) ->setBook($book->getTitle(), $group_name) ->setHeader($header) ->addClass('diviner-view'); diff --git a/src/applications/diviner/controller/DivinerBookController.php b/src/applications/diviner/controller/DivinerBookController.php index 1aa8790ffa..4e0ae3524b 100644 --- a/src/applications/diviner/controller/DivinerBookController.php +++ b/src/applications/diviner/controller/DivinerBookController.php @@ -45,7 +45,7 @@ final class DivinerBookController extends DivinerController { ->setName($book->getRepository()->getMonogram())); } - $document = new PHUIDocumentViewPro(); + $document = new PHUIDocumentView(); $document->setHeader($header); $document->addClass('diviner-view'); diff --git a/src/applications/diviner/controller/DivinerMainController.php b/src/applications/diviner/controller/DivinerMainController.php index e7d179c077..400fb48d0f 100644 --- a/src/applications/diviner/controller/DivinerMainController.php +++ b/src/applications/diviner/controller/DivinerMainController.php @@ -27,7 +27,7 @@ final class DivinerMainController extends DivinerController { ->setHeader(pht('Documentation Books')) ->addActionLink($query_button); - $document = new PHUIDocumentViewPro(); + $document = new PHUIDocumentView(); $document->setHeader($header); $document->addClass('diviner-view'); diff --git a/src/applications/guides/module/PhabricatorGuideInstallModule.php b/src/applications/guides/module/PhabricatorGuideInstallModule.php index 7a46b20027..172ff7a17b 100644 --- a/src/applications/guides/module/PhabricatorGuideInstallModule.php +++ b/src/applications/guides/module/PhabricatorGuideInstallModule.php @@ -169,7 +169,7 @@ final class PhabricatorGuideInstallModule extends PhabricatorGuideModule { $intro = new PHUIRemarkupView($viewer, $intro); - $intro = id(new PHUIDocumentViewPro()) + $intro = id(new PHUIDocumentView()) ->appendChild($intro); return array($intro, $guide_items); diff --git a/src/applications/guides/module/PhabricatorGuideQuickStartModule.php b/src/applications/guides/module/PhabricatorGuideQuickStartModule.php index c06e320df7..8c4b4c2606 100644 --- a/src/applications/guides/module/PhabricatorGuideQuickStartModule.php +++ b/src/applications/guides/module/PhabricatorGuideQuickStartModule.php @@ -206,7 +206,7 @@ final class PhabricatorGuideQuickStartModule extends PhabricatorGuideModule { 'these features at your own pace.'); $intro = new PHUIRemarkupView($viewer, $intro); - $intro = id(new PHUIDocumentViewPro()) + $intro = id(new PHUIDocumentView()) ->appendChild($intro); return array($intro, $guide_items); diff --git a/src/applications/legalpad/controller/LegalpadDocumentSignController.php b/src/applications/legalpad/controller/LegalpadDocumentSignController.php index f19cf43d0e..1748dba452 100644 --- a/src/applications/legalpad/controller/LegalpadDocumentSignController.php +++ b/src/applications/legalpad/controller/LegalpadDocumentSignController.php @@ -272,7 +272,7 @@ final class LegalpadDocumentSignController extends LegalpadController { $preamble_box->addPropertyList($preamble); } - $content = id(new PHUIDocumentViewPro()) + $content = id(new PHUIDocumentView()) ->addClass('legalpad') ->setHeader($header) ->appendChild( diff --git a/src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php b/src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php index 2979e92229..43ed2e957e 100644 --- a/src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php +++ b/src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php @@ -132,7 +132,7 @@ final class PhabricatorApplicationEmailCommandsController $header = id(new PHUIHeaderView()) ->setHeader($title); - $document = id(new PHUIDocumentViewPro()) + $document = id(new PHUIDocumentView()) ->setHeader($header) ->appendChild($info_view) ->appendChild($content_box); diff --git a/src/applications/phame/controller/PhameHomeController.php b/src/applications/phame/controller/PhameHomeController.php index 037026fa80..bf263e97a8 100644 --- a/src/applications/phame/controller/PhameHomeController.php +++ b/src/applications/phame/controller/PhameHomeController.php @@ -84,7 +84,7 @@ final class PhameHomeController extends PhamePostController { pht('Recent Posts'), $this->getApplicationURI('post/')); - $page = id(new PHUIDocumentViewPro()) + $page = id(new PHUIDocumentView()) ->setHeader($header) ->appendChild($post_list); diff --git a/src/applications/phame/controller/blog/PhameBlogViewController.php b/src/applications/phame/controller/blog/PhameBlogViewController.php index 08b23e5a95..e9e422aeb1 100644 --- a/src/applications/phame/controller/blog/PhameBlogViewController.php +++ b/src/applications/phame/controller/blog/PhameBlogViewController.php @@ -85,7 +85,7 @@ final class PhameBlogViewController extends PhameLiveController { } } - $page = id(new PHUIDocumentViewPro()) + $page = id(new PHUIDocumentView()) ->setHeader($header) ->appendChild($post_list); diff --git a/src/applications/phame/controller/post/PhamePostViewController.php b/src/applications/phame/controller/post/PhamePostViewController.php index 63adedb7ae..11d94d2f94 100644 --- a/src/applications/phame/controller/post/PhamePostViewController.php +++ b/src/applications/phame/controller/post/PhamePostViewController.php @@ -30,7 +30,7 @@ final class PhamePostViewController $header->setActionList($actions); } - $document = id(new PHUIDocumentViewPro()) + $document = id(new PHUIDocumentView()) ->setHeader($header); if ($moved) { diff --git a/src/applications/phriction/controller/PhrictionDocumentController.php b/src/applications/phriction/controller/PhrictionDocumentController.php index c8ffb86ce8..57dad25ab5 100644 --- a/src/applications/phriction/controller/PhrictionDocumentController.php +++ b/src/applications/phriction/controller/PhrictionDocumentController.php @@ -227,7 +227,7 @@ final class PhrictionDocumentController } $prop_list = phutil_tag_div('phui-document-view-pro-box', $prop_list); - $page_content = id(new PHUIDocumentViewPro()) + $page_content = id(new PHUIDocumentView()) ->setHeader($header) ->setToc($toc) ->appendChild( @@ -241,11 +241,12 @@ final class PhrictionDocumentController ->setTitle($page_title) ->setCrumbs($crumbs) ->setPageObjectPHIDs(array($document->getPHID())) - ->appendChild(array( - $page_content, - $prop_list, - $children, - )); + ->appendChild( + array( + $page_content, + $prop_list, + $children, + )); } diff --git a/src/applications/transactions/editengine/PhabricatorEditEngine.php b/src/applications/transactions/editengine/PhabricatorEditEngine.php index ad495a3a44..579b53a989 100644 --- a/src/applications/transactions/editengine/PhabricatorEditEngine.php +++ b/src/applications/transactions/editengine/PhabricatorEditEngine.php @@ -1679,7 +1679,7 @@ abstract class PhabricatorEditEngine ->setUser($viewer) ->setFields($fields); - $document = id(new PHUIDocumentViewPro()) + $document = id(new PHUIDocumentView()) ->setUser($viewer) ->setHeader($header) ->appendChild($help_view); diff --git a/src/applications/typeahead/controller/PhabricatorTypeaheadFunctionHelpController.php b/src/applications/typeahead/controller/PhabricatorTypeaheadFunctionHelpController.php index 27b30a6278..a7a1f55caa 100644 --- a/src/applications/typeahead/controller/PhabricatorTypeaheadFunctionHelpController.php +++ b/src/applications/typeahead/controller/PhabricatorTypeaheadFunctionHelpController.php @@ -142,7 +142,7 @@ final class PhabricatorTypeaheadFunctionHelpController $header = id(new PHUIHeaderView()) ->setHeader($title); - $document = id(new PHUIDocumentViewPro()) + $document = id(new PHUIDocumentView()) ->setHeader($header) ->appendChild($content_box); diff --git a/src/view/phui/PHUIDocumentViewPro.php b/src/view/phui/PHUIDocumentView.php similarity index 98% rename from src/view/phui/PHUIDocumentViewPro.php rename to src/view/phui/PHUIDocumentView.php index 51ecc3526e..5b6bf9fcf9 100644 --- a/src/view/phui/PHUIDocumentViewPro.php +++ b/src/view/phui/PHUIDocumentView.php @@ -1,6 +1,6 @@ setHeader(pht('%s (Preview)', $this->header)); - $content = id(new PHUIDocumentViewPro()) + $content = id(new PHUIDocumentView()) ->setHeader($header) ->appendChild($preview); }