From fd46c597aec5cc44707dc99e153da749c5389907 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 4 Feb 2020 15:03:17 -0800 Subject: [PATCH] When sorting subscriber references for display in the curtain UI, sort without case sensitivity Summary: Ref T13486. Currently, "Zarbo" sorts above "alice", but this isn't expected for a list of (mostly) human usernames. Test Plan: Loaded a task with subscribers with mixed-case usernames. Maniphest Tasks: T13486 Differential Revision: https://secure.phabricator.com/D20969 --- .../PhabricatorSubscriptionsCurtainExtension.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/applications/subscriptions/engineextension/PhabricatorSubscriptionsCurtainExtension.php b/src/applications/subscriptions/engineextension/PhabricatorSubscriptionsCurtainExtension.php index 639e96eb86..a6df97b095 100644 --- a/src/applications/subscriptions/engineextension/PhabricatorSubscriptionsCurtainExtension.php +++ b/src/applications/subscriptions/engineextension/PhabricatorSubscriptionsCurtainExtension.php @@ -123,7 +123,9 @@ final class PhabricatorSubscriptionsCurtainExtension $handle = $handles[$subscriber_phid]; if ($handle->isComplete()) { $is_complete = true; + $sort_name = $handle->getLinkName(); + $sort_name = phutil_utf8_strtolower($sort_name); } } }