revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 07:12:41 +01:00
Code Issues Releases Wiki Activity

Minor, really fix empty reference properties in diffusion

Browse source 
Summary:
Oh man, after the explode/map, the output when no references is actually

  array(1) {
    [0]=> string(0) ""
  }

.. making the falsey check fail to work as expected.

Test Plan: same as D2892, but with a little more scrutiny :p

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D2893
This commit is contained in:
David Reuss 2012-06-30 06:43:27 -07:00 committed by epriestley
parent 19d58564d1
commit fd94700d69
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/applications/diffusion/controller/DiffusionCommitController.php
View file

@ -845,12 +845,11 @@ final class DiffusionCommitController extends DiffusionController {
// %d, gives a weird output format // %d, gives a weird output format
// similar to (remote/one, remote/two, remote/three) // similar to (remote/one, remote/two, remote/three)
$refs = trim($stdout, "() \n"); $refs = trim($stdout, "() \n");
$refs = explode(',', $refs);
$refs = array_map('trim', $refs);
if (!$refs) { if (!$refs) {
return null; return null;
} }
$refs = explode(',', $refs);
$refs = array_map('trim', $refs);
$ref_links = array(); $ref_links = array();
foreach ($refs as $ref) { foreach ($refs as $ref) {