From fdc7b8672b5ef1b4e29b27f0cd3e51374e786f26 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Tue, 25 Mar 2014 13:56:11 -0700
Subject: [PATCH] Internalize Maniphest task status colors

Summary: Ref T1812. These are a bit fluff and don't make too much sense to make configurable, at least for now.

Test Plan: Grepped for external callers.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1812

Differential Revision: https://secure.phabricator.com/D8581
---
 .../constants/ManiphestTaskStatus.php         | 40 ++++---------------
 1 file changed, 8 insertions(+), 32 deletions(-)

diff --git a/src/applications/maniphest/constants/ManiphestTaskStatus.php b/src/applications/maniphest/constants/ManiphestTaskStatus.php
index f4df0e4fdc..8e2b045e68 100644
--- a/src/applications/maniphest/constants/ManiphestTaskStatus.php
+++ b/src/applications/maniphest/constants/ManiphestTaskStatus.php
@@ -9,9 +9,6 @@ final class ManiphestTaskStatus extends ManiphestConstants {
   const STATUS_CLOSED_DUPLICATE   = 4;
   const STATUS_CLOSED_SPITE       = 5;
 
-  const COLOR_STATUS_OPEN = 'status';
-  const COLOR_STATUS_CLOSED = 'status-dark';
-
   public static function getTaskStatusMap() {
     $open = pht('Open');
     $resolved = pht('Resolved');
@@ -60,39 +57,18 @@ final class ManiphestTaskStatus extends ManiphestConstants {
     return idx($map, $status, '???');
   }
 
-  public static function getTaskStatusColor($status) {
-    $default = self::COLOR_STATUS_OPEN;
-
-    $map = array(
-      self::STATUS_OPEN             => self::COLOR_STATUS_OPEN,
-      self::STATUS_CLOSED_RESOLVED  => self::COLOR_STATUS_CLOSED,
-      self::STATUS_CLOSED_WONTFIX   => self::COLOR_STATUS_CLOSED,
-      self::STATUS_CLOSED_INVALID   => self::COLOR_STATUS_CLOSED,
-      self::STATUS_CLOSED_DUPLICATE => self::COLOR_STATUS_CLOSED,
-      self::STATUS_CLOSED_SPITE     => self::COLOR_STATUS_CLOSED,
-    );
-    return idx($map, $status, $default);
-  }
-
-  public static function getIcon($status) {
-    $default = 'oh-open';
-    $map = array(
-      self::STATUS_OPEN             => 'oh-open',
-      self::STATUS_CLOSED_RESOLVED  => 'oh-closed-dark',
-      self::STATUS_CLOSED_WONTFIX   => 'oh-closed-dark',
-      self::STATUS_CLOSED_INVALID   => 'oh-closed-dark',
-      self::STATUS_CLOSED_DUPLICATE => 'oh-closed-dark',
-      self::STATUS_CLOSED_SPITE     => 'oh-closed-dark',
-    );
-    return idx($map, $status, $default);
-  }
-
   public static function renderFullDescription($status) {
-    $color = self::getTaskStatusColor($status);
+    if (self::isOpenStatus($status)) {
+      $color = 'status';
+      $icon = 'oh-open';
+    } else {
+      $color = 'status-dark';
+      $icon = 'oh-closed-dark';
+    }
 
     $img = id(new PHUIIconView())
       ->setSpriteSheet(PHUIIconView::SPRITE_STATUS)
-      ->setSpriteIcon(self::getIcon($status));
+      ->setSpriteIcon($icon);
 
     $tag = phutil_tag(
       'span',