From fdd1357ce24f4a9af284a58c52864c9c42f1d3c7 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Tue, 30 Dec 2014 02:56:42 -0800
Subject: [PATCH] Fix `next_src` being defined as a global variable

Summary: This variable should be local, not global. This silences a bunch of JSHint warnings.

Test Plan: `arc lint`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11067
---
 resources/celerity/map.php                    | 60 +++++++++----------
 .../pholio/behavior-pholio-mock-view.js       |  2 +-
 2 files changed, 31 insertions(+), 31 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index d0413d3b15..650e5e53fd 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -394,7 +394,7 @@ return array(
     'rsrc/js/application/passphrase/phame-credential-control.js' => '3d51a746',
     'rsrc/js/application/phame/phame-post-preview.js' => 'be807912',
     'rsrc/js/application/pholio/behavior-pholio-mock-edit.js' => '9c2623f4',
-    'rsrc/js/application/pholio/behavior-pholio-mock-view.js' => '9b04250e',
+    'rsrc/js/application/pholio/behavior-pholio-mock-view.js' => 'e58bf807',
     'rsrc/js/application/phortune/behavior-balanced-payment-form.js' => 'b2c03e60',
     'rsrc/js/application/phortune/behavior-stripe-payment-form.js' => '3f5d6dbf',
     'rsrc/js/application/phortune/behavior-test-payment-form.js' => 'fc91ab6c',
@@ -623,7 +623,7 @@ return array(
     'javelin-behavior-phabricator-watch-anchor' => '06e05112',
     'javelin-behavior-phame-post-preview' => 'be807912',
     'javelin-behavior-pholio-mock-edit' => '9c2623f4',
-    'javelin-behavior-pholio-mock-view' => '9b04250e',
+    'javelin-behavior-pholio-mock-view' => 'e58bf807',
     'javelin-behavior-phui-object-box-tabs' => '2bfa2836',
     'javelin-behavior-phui-timeline-dropdown-menu' => '4d94d9c3',
     'javelin-behavior-policy-control' => 'f3fef818',
@@ -848,20 +848,6 @@ return array(
       'javelin-stratcom',
       'javelin-workflow',
     ),
-    '7319e029' => array(
-      'javelin-behavior',
-      'javelin-dom',
-    ),
-    '97258e55' => array(
-      'javelin-install',
-      'javelin-stratcom',
-      'javelin-util',
-      'javelin-behavior',
-      'javelin-json',
-      'javelin-dom',
-      'javelin-resource',
-      'javelin-routable',
-    ),
     '06e05112' => array(
       'javelin-behavior',
       'javelin-stratcom',
@@ -1253,6 +1239,10 @@ return array(
       'javelin-stratcom',
       'phabricator-prefab',
     ),
+    '7319e029' => array(
+      'javelin-behavior',
+      'javelin-dom',
+    ),
     '76b9fc3e' => array(
       'javelin-behavior',
       'javelin-stratcom',
@@ -1404,25 +1394,21 @@ return array(
       'javelin-workflow',
       'javelin-util',
     ),
+    '97258e55' => array(
+      'javelin-install',
+      'javelin-stratcom',
+      'javelin-util',
+      'javelin-behavior',
+      'javelin-json',
+      'javelin-dom',
+      'javelin-resource',
+      'javelin-routable',
+    ),
     '988040b4' => array(
       'javelin-install',
       'javelin-dom',
       'javelin-reactor-dom',
     ),
-    '9b04250e' => array(
-      'javelin-behavior',
-      'javelin-util',
-      'javelin-stratcom',
-      'javelin-dom',
-      'javelin-vector',
-      'javelin-magical-init',
-      'javelin-request',
-      'javelin-history',
-      'javelin-workflow',
-      'javelin-mask',
-      'javelin-behavior-device',
-      'phabricator-keyboard-shortcut',
-    ),
     '9c2623f4' => array(
       'javelin-behavior',
       'javelin-stratcom',
@@ -1789,6 +1775,20 @@ return array(
       'javelin-workflow',
       'javelin-magical-init',
     ),
+    'e58bf807' => array(
+      'javelin-behavior',
+      'javelin-util',
+      'javelin-stratcom',
+      'javelin-dom',
+      'javelin-vector',
+      'javelin-magical-init',
+      'javelin-request',
+      'javelin-history',
+      'javelin-workflow',
+      'javelin-mask',
+      'javelin-behavior-device',
+      'phabricator-keyboard-shortcut',
+    ),
     'e5b406f9' => array(
       'javelin-install',
       'javelin-dom',
diff --git a/webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js b/webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js
index 2593cef2a4..fc52b51f59 100644
--- a/webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js
+++ b/webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js
@@ -755,7 +755,7 @@ JX.behavior('pholio-mock-view', function(config) {
   }
 
   function preload_next() {
-    next_src = preload[0];
+    var next_src = preload[0];
     if (!next_src) {
       return;
     }