mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-18 19:40:55 +01:00
Change wording of "Show Entire File" to "Show All Context"
Summary: Fixes T10139. This clarification seems reasonable to me. Test Plan: - Viewed a revision with context. - Clicked "Show All Context". - Saw "All Context Shown". {F1060624} {F1060625} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10139 Differential Revision: https://secure.phabricator.com/D15009
This commit is contained in:
parent
102eacbfb7
commit
fdd5500fec
4 changed files with 33 additions and 33 deletions
|
@ -11,7 +11,7 @@ return array(
|
||||||
'core.pkg.js' => '6ae03393',
|
'core.pkg.js' => '6ae03393',
|
||||||
'darkconsole.pkg.js' => 'e7393ebb',
|
'darkconsole.pkg.js' => 'e7393ebb',
|
||||||
'differential.pkg.css' => '2de124c9',
|
'differential.pkg.css' => '2de124c9',
|
||||||
'differential.pkg.js' => '64e69521',
|
'differential.pkg.js' => 'f83532f8',
|
||||||
'diffusion.pkg.css' => 'f45955ed',
|
'diffusion.pkg.css' => 'f45955ed',
|
||||||
'diffusion.pkg.js' => '3a9a8bfa',
|
'diffusion.pkg.js' => '3a9a8bfa',
|
||||||
'maniphest.pkg.css' => '4845691a',
|
'maniphest.pkg.css' => '4845691a',
|
||||||
|
@ -375,13 +375,13 @@ return array(
|
||||||
'rsrc/js/application/dashboard/behavior-dashboard-move-panels.js' => '82439934',
|
'rsrc/js/application/dashboard/behavior-dashboard-move-panels.js' => '82439934',
|
||||||
'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375',
|
'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375',
|
||||||
'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63',
|
'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63',
|
||||||
'rsrc/js/application/differential/ChangesetViewManager.js' => '58562350',
|
'rsrc/js/application/differential/ChangesetViewManager.js' => 'a2828756',
|
||||||
'rsrc/js/application/differential/DifferentialInlineCommentEditor.js' => '64a5550f',
|
'rsrc/js/application/differential/DifferentialInlineCommentEditor.js' => '64a5550f',
|
||||||
'rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js' => 'e10f8e18',
|
'rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js' => 'e10f8e18',
|
||||||
'rsrc/js/application/differential/behavior-comment-jump.js' => '4fdb476d',
|
'rsrc/js/application/differential/behavior-comment-jump.js' => '4fdb476d',
|
||||||
'rsrc/js/application/differential/behavior-comment-preview.js' => 'b064af76',
|
'rsrc/js/application/differential/behavior-comment-preview.js' => 'b064af76',
|
||||||
'rsrc/js/application/differential/behavior-diff-radios.js' => 'e1ff79b1',
|
'rsrc/js/application/differential/behavior-diff-radios.js' => 'e1ff79b1',
|
||||||
'rsrc/js/application/differential/behavior-dropdown-menus.js' => '2035b9cb',
|
'rsrc/js/application/differential/behavior-dropdown-menus.js' => '9a6b9324',
|
||||||
'rsrc/js/application/differential/behavior-edit-inline-comments.js' => '65ef6074',
|
'rsrc/js/application/differential/behavior-edit-inline-comments.js' => '65ef6074',
|
||||||
'rsrc/js/application/differential/behavior-keyboard-nav.js' => '2c426492',
|
'rsrc/js/application/differential/behavior-keyboard-nav.js' => '2c426492',
|
||||||
'rsrc/js/application/differential/behavior-populate.js' => '8694b1df',
|
'rsrc/js/application/differential/behavior-populate.js' => '8694b1df',
|
||||||
|
@ -523,7 +523,7 @@ return array(
|
||||||
'aphront-typeahead-control-css' => '0e403212',
|
'aphront-typeahead-control-css' => '0e403212',
|
||||||
'auth-css' => '0877ed6e',
|
'auth-css' => '0877ed6e',
|
||||||
'bulk-job-css' => 'df9c1d4a',
|
'bulk-job-css' => 'df9c1d4a',
|
||||||
'changeset-view-manager' => '58562350',
|
'changeset-view-manager' => 'a2828756',
|
||||||
'conduit-api-css' => '7bc725c4',
|
'conduit-api-css' => '7bc725c4',
|
||||||
'config-options-css' => '0ede4c9b',
|
'config-options-css' => '0ede4c9b',
|
||||||
'config-welcome-css' => '6abd79be',
|
'config-welcome-css' => '6abd79be',
|
||||||
|
@ -588,7 +588,7 @@ return array(
|
||||||
'javelin-behavior-differential-add-reviewers-and-ccs' => 'e10f8e18',
|
'javelin-behavior-differential-add-reviewers-and-ccs' => 'e10f8e18',
|
||||||
'javelin-behavior-differential-comment-jump' => '4fdb476d',
|
'javelin-behavior-differential-comment-jump' => '4fdb476d',
|
||||||
'javelin-behavior-differential-diff-radios' => 'e1ff79b1',
|
'javelin-behavior-differential-diff-radios' => 'e1ff79b1',
|
||||||
'javelin-behavior-differential-dropdown-menus' => '2035b9cb',
|
'javelin-behavior-differential-dropdown-menus' => '9a6b9324',
|
||||||
'javelin-behavior-differential-edit-inline-comments' => '65ef6074',
|
'javelin-behavior-differential-edit-inline-comments' => '65ef6074',
|
||||||
'javelin-behavior-differential-feedback-preview' => 'b064af76',
|
'javelin-behavior-differential-feedback-preview' => 'b064af76',
|
||||||
'javelin-behavior-differential-keyboard-navigation' => '2c426492',
|
'javelin-behavior-differential-keyboard-navigation' => '2c426492',
|
||||||
|
@ -978,18 +978,6 @@ return array(
|
||||||
'phuix-icon-view',
|
'phuix-icon-view',
|
||||||
'javelin-behavior-phabricator-gesture',
|
'javelin-behavior-phabricator-gesture',
|
||||||
),
|
),
|
||||||
'2035b9cb' => array(
|
|
||||||
'javelin-behavior',
|
|
||||||
'javelin-dom',
|
|
||||||
'javelin-util',
|
|
||||||
'javelin-stratcom',
|
|
||||||
'javelin-workflow',
|
|
||||||
'phuix-dropdown-menu',
|
|
||||||
'phuix-action-list-view',
|
|
||||||
'phuix-action-view',
|
|
||||||
'phabricator-phtize',
|
|
||||||
'changeset-view-manager',
|
|
||||||
),
|
|
||||||
'21ba5861' => array(
|
'21ba5861' => array(
|
||||||
'javelin-behavior',
|
'javelin-behavior',
|
||||||
'javelin-dom',
|
'javelin-dom',
|
||||||
|
@ -1210,16 +1198,6 @@ return array(
|
||||||
'javelin-request',
|
'javelin-request',
|
||||||
'javelin-util',
|
'javelin-util',
|
||||||
),
|
),
|
||||||
58562350 => array(
|
|
||||||
'javelin-dom',
|
|
||||||
'javelin-util',
|
|
||||||
'javelin-stratcom',
|
|
||||||
'javelin-install',
|
|
||||||
'javelin-workflow',
|
|
||||||
'javelin-router',
|
|
||||||
'javelin-behavior-device',
|
|
||||||
'javelin-vector',
|
|
||||||
),
|
|
||||||
'59a7976a' => array(
|
'59a7976a' => array(
|
||||||
'javelin-install',
|
'javelin-install',
|
||||||
'javelin-dom',
|
'javelin-dom',
|
||||||
|
@ -1571,6 +1549,18 @@ return array(
|
||||||
'javelin-dom',
|
'javelin-dom',
|
||||||
'javelin-reactor-dom',
|
'javelin-reactor-dom',
|
||||||
),
|
),
|
||||||
|
'9a6b9324' => array(
|
||||||
|
'javelin-behavior',
|
||||||
|
'javelin-dom',
|
||||||
|
'javelin-util',
|
||||||
|
'javelin-stratcom',
|
||||||
|
'javelin-workflow',
|
||||||
|
'phuix-dropdown-menu',
|
||||||
|
'phuix-action-list-view',
|
||||||
|
'phuix-action-view',
|
||||||
|
'phabricator-phtize',
|
||||||
|
'changeset-view-manager',
|
||||||
|
),
|
||||||
'9e54692d' => array(
|
'9e54692d' => array(
|
||||||
'javelin-install',
|
'javelin-install',
|
||||||
'javelin-dom',
|
'javelin-dom',
|
||||||
|
@ -1610,6 +1600,16 @@ return array(
|
||||||
'javelin-vector',
|
'javelin-vector',
|
||||||
'javelin-install',
|
'javelin-install',
|
||||||
),
|
),
|
||||||
|
'a2828756' => array(
|
||||||
|
'javelin-dom',
|
||||||
|
'javelin-util',
|
||||||
|
'javelin-stratcom',
|
||||||
|
'javelin-install',
|
||||||
|
'javelin-workflow',
|
||||||
|
'javelin-router',
|
||||||
|
'javelin-behavior-device',
|
||||||
|
'javelin-vector',
|
||||||
|
),
|
||||||
'a464fe03' => array(
|
'a464fe03' => array(
|
||||||
'javelin-behavior',
|
'javelin-behavior',
|
||||||
'javelin-uri',
|
'javelin-uri',
|
||||||
|
|
|
@ -129,8 +129,8 @@ final class DifferentialChangesetListView extends AphrontView {
|
||||||
array(
|
array(
|
||||||
'pht' => array(
|
'pht' => array(
|
||||||
'Open in Editor' => pht('Open in Editor'),
|
'Open in Editor' => pht('Open in Editor'),
|
||||||
'Show Entire File' => pht('Show Entire File'),
|
'Show All Context' => pht('Show All Context'),
|
||||||
'Entire File Shown' => pht('Entire File Shown'),
|
'All Context Shown' => pht('All Context Shown'),
|
||||||
"Can't Toggle Unloaded File" => pht("Can't Toggle Unloaded File"),
|
"Can't Toggle Unloaded File" => pht("Can't Toggle Unloaded File"),
|
||||||
'Expand File' => pht('Expand File'),
|
'Expand File' => pht('Expand File'),
|
||||||
'Collapse File' => pht('Collapse File'),
|
'Collapse File' => pht('Collapse File'),
|
||||||
|
|
|
@ -141,7 +141,7 @@ JX.install('ChangesetViewManager', {
|
||||||
* Load missing context in a changeset.
|
* Load missing context in a changeset.
|
||||||
*
|
*
|
||||||
* We do this when the user clicks "Show X Lines". We also expand all of
|
* We do this when the user clicks "Show X Lines". We also expand all of
|
||||||
* the missing context when they "Show Entire File".
|
* the missing context when they "Show All Context".
|
||||||
*
|
*
|
||||||
* @param string Line range specification, like "0-40/0-20".
|
* @param string Line range specification, like "0-40/0-20".
|
||||||
* @param node Row where the context should be rendered after loading.
|
* @param node Row where the context should be rendered after loading.
|
||||||
|
@ -162,7 +162,7 @@ JX.install('ChangesetViewManager', {
|
||||||
|
|
||||||
if (bulk) {
|
if (bulk) {
|
||||||
// If we're loading a bunch of these because the viewer clicked
|
// If we're loading a bunch of these because the viewer clicked
|
||||||
// "Show Entire File Content" or similar, use lower-priority requests
|
// "Show All Context" or similar, use lower-priority requests
|
||||||
// and draw a progress bar.
|
// and draw a progress bar.
|
||||||
this._startContentWorkflow(workflow);
|
this._startContentWorkflow(workflow);
|
||||||
} else {
|
} else {
|
||||||
|
|
|
@ -180,7 +180,7 @@ JX.behavior('differential-dropdown-menus', function(config) {
|
||||||
if (nodes.length) {
|
if (nodes.length) {
|
||||||
reveal_item
|
reveal_item
|
||||||
.setDisabled(false)
|
.setDisabled(false)
|
||||||
.setName(pht('Show Entire File'))
|
.setName(pht('Show All Context'))
|
||||||
.setIcon('fa-file-o')
|
.setIcon('fa-file-o')
|
||||||
.setHandler(function(e) {
|
.setHandler(function(e) {
|
||||||
show_more(JX.$(data.containerID));
|
show_more(JX.$(data.containerID));
|
||||||
|
@ -191,7 +191,7 @@ JX.behavior('differential-dropdown-menus', function(config) {
|
||||||
reveal_item
|
reveal_item
|
||||||
.setDisabled(true)
|
.setDisabled(true)
|
||||||
.setIcon('fa-file')
|
.setIcon('fa-file')
|
||||||
.setName(pht('Entire File Shown'))
|
.setName(pht('All Context Shown'))
|
||||||
.setHandler(function(e) { e.prevent(); });
|
.setHandler(function(e) { e.prevent(); });
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue