revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Don't render the Maniphest edit form bottom-of-page preview panel if "Description" is locked or hidden

Browse source 
Summary:
See <https://discourse.phabricator-community.org/t/hidden-description-field-in-maniphest-task-breaks-form/1432>.

If you hide the "Description" field in Maniphest, we still try to render a remarkup preview for it. This causes a JS error and a nonfunctional element on the page.

Instead, hide the preview panel if the field has been locked or hidden.

Test Plan:
  - Hid the field, loaded the form, no more preview panel / JS error.
  - Used a normal form with the field visible, saw a normal preview.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19432
This commit is contained in:
epriestley 2018-05-07 13:55:00 -07:00
parent a4a22dd2f8
commit fddb506e98
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/transactions/editfield/PhabricatorEditField.php
View file

@ -302,6 +302,14 @@ abstract class PhabricatorEditField extends Phobject {
} }
public function getPreviewPanel() { public function getPreviewPanel() {
if ($this->getIsHidden()) {
return null;
}
if ($this->getIsLocked()) {
return null;
}
return $this->previewPanel; return $this->previewPanel;
} }