revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 20:10:55 +01:00
Code Issues Releases Wiki Activity

Use shouldAllowPublic(), not shouldRequireLogin(), for Legalpad

Browse source 
Summary: This got written a while ago and is using slightly incorrect gating on logged-out users. The names of these methods should probably be more clear too, but basically "shouldAllowPublic()" is for "this page may be usable to logged-out users, if policies allow it", while "shouldRequireLogin()" is for "this page should skip various credential checks". One of the skipped checks is email verification. This method should maybe be something like "isAuthenticationRelatedOrNoncredentialPage()" but I don't have a good name for that.

Test Plan: Unverified users are now prompted to verify email when viewing a legalpad document, instead of allowed to sign it.

Reviewers: rush898, chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D9857
This commit is contained in:
epriestley 2014-07-09 08:01:34 -07:00
parent a89ce7e9a2
commit fe29db6b92
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/legalpad/controller/LegalpadDocumentDoneController.php
View file

@ -2,7 +2,7 @@
final class LegalpadDocumentDoneController extends LegalpadController {
public function shouldRequireLogin() {
public function shouldAllowPublic() {
return false;
}

2
src/applications/legalpad/controller/LegalpadDocumentSignController.php
View file

@ -4,7 +4,7 @@ final class LegalpadDocumentSignController extends LegalpadController {
private $id;
public function shouldRequireLogin() {
public function shouldAllowPublic() {
return false;
}