1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-20 05:42:40 +01:00

Render the clone URI input field as readonly.

Summary:
There's no particular reason to allow the user to edit the clone URI field in Diffusion; editing it has no meaning and if you fat finger the keyboard, it's quite possible that the user will either accidentally clear and/or modify the URI before copying (bit me this morning).

Adding a readonly attribute to the input field allows the same benefit (URI is easily selectable) while preventing such accidental input.  Fixes T4246.

Test Plan: Verified that the desired behavior is present in both Chrome, Safari, and Firefox. Field remains selectable with one click, but field is not editable.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T4246

Differential Revision: https://secure.phabricator.com/D7810
This commit is contained in:
William R. Otte 2013-12-20 13:47:25 -06:00
parent 134c8f5547
commit ff13bb8538

View file

@ -531,6 +531,7 @@ final class DiffusionRepositoryController extends DiffusionController {
'value' => (string)$uri, 'value' => (string)$uri,
'class' => 'diffusion-clone-uri', 'class' => 'diffusion-clone-uri',
'sigil' => 'select-on-click', 'sigil' => 'select-on-click',
'readonly' => 'true',
)); ));
$extras = array(); $extras = array();