From ff205964cffce518232249e54e567fbe5ec9af65 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Mon, 8 May 2017 13:29:55 -0700
Subject: [PATCH] Make macro audio errors more clear

Summary: Ref T12685. I bamboozled myself.

Test Plan: {F4945786}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12685

Differential Revision: https://secure.phabricator.com/D17847
---
 .../macro/controller/PhabricatorMacroAudioController.php  | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/applications/macro/controller/PhabricatorMacroAudioController.php b/src/applications/macro/controller/PhabricatorMacroAudioController.php
index 382c82ae3a..fb6eba8401 100644
--- a/src/applications/macro/controller/PhabricatorMacroAudioController.php
+++ b/src/applications/macro/controller/PhabricatorMacroAudioController.php
@@ -50,7 +50,9 @@ final class PhabricatorMacroAudioController extends PhabricatorMacroController {
 
         if ($file) {
           if (!$file->isAudio()) {
-            $errors[] = pht('You must upload audio.');
+            $errors[] = pht(
+              'The file you uploaded is invalid: it is not recognizable as '.
+              'a valid audio file.');
             $e_file = pht('Invalid');
           } else {
             $xactions[] = id(new PhabricatorMacroTransaction())
@@ -59,7 +61,9 @@ final class PhabricatorMacroAudioController extends PhabricatorMacroController {
               ->setNewValue($file->getPHID());
           }
         } else {
-          $errors[] = pht('You must upload an audio file.');
+          $errors[] = pht(
+            'To change the audio for a macro, you must upload an audio '.
+            'file.');
           $e_file = pht('Required');
         }
       }