revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 12:00:55 +01:00
Code Issues Releases Wiki Activity

Improve error message for "phd stop" with bad PID

Browse source 
Summary: "phd launch ircbot" works but "phd stop ircbot" gives you a potentially
confusing message. Improve messaging.

Test Plan: Ran "phd stop ircbot", "phd stop 87888" (actual PID)

Reviewers: btrahan, jungejason

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T791

Differential Revision: https://secure.phabricator.com/D1457
This commit is contained in:
epriestley 2012-01-19 11:06:05 -08:00
parent 8b4b614d15
commit ff339e152e
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/infrastructure/daemon/control/PhabricatorDaemonControl.php
View file

@ -84,8 +84,11 @@ final class PhabricatorDaemonControl {
} else { } else {
// We were given a PID or set of PIDs to kill. // We were given a PID or set of PIDs to kill.
foreach ($pids as $key => $pid) { foreach ($pids as $key => $pid) {
if (empty($daemons[$pid])) { if (!preg_match('/^\d+$/', $pid)) {
echo "{$pid} is not Phabricator-controlled. Not killing.\n"; echo "'{$pid}' is not a valid PID.\n";
continue;
} else if (empty($daemons[$pid])) {
echo "'{$pid}' is not Phabricator-controlled PID. Not killing.\n";
continue; continue;
} else { } else {
$running[] = $daemons[$pid]; $running[] = $daemons[$pid];