revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-08 04:48:28 +01:00
Code Issues Releases Wiki Activity

(stable) Add an "isDone" flag to "transaction.search" for Differential inline comments

Browse source 
Summary: See PHI1684. Expose the published state of the "Done" checkbox to the API.

Test Plan: Made API calls on a comment in all four states, got correct published states via the API in all cases.

Differential Revision: https://secure.phabricator.com/D21059
This commit is contained in:
epriestley 2020-04-05 09:02:36 -07:00
parent 6a62b63db1
commit ff348b40f9
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php
View file

@ -38,6 +38,14 @@ final class DifferentialRevisionInlineTransaction
$changeset = $data[$comment->getChangesetID()]; $changeset = $data[$comment->getChangesetID()];
$diff = $changeset->getDiff(); $diff = $changeset->getDiff();
$is_done = false;
switch ($comment->getFixedState()) {
case PhabricatorInlineCommentInterface::STATE_DONE:
case PhabricatorInlineCommentInterface::STATE_UNDRAFT:
$is_done = true;
break;
}
return array( return array(
'diff' => array( 'diff' => array(
'id' => (int)$diff->getID(), 'id' => (int)$diff->getID(),
@ -47,6 +55,7 @@ final class DifferentialRevisionInlineTransaction
'line' => (int)$comment->getLineNumber(), 'line' => (int)$comment->getLineNumber(),
'length' => (int)($comment->getLineLength() + 1), 'length' => (int)($comment->getLineLength() + 1),
'replyToCommentPHID' => $comment->getReplyToCommentPHID(), 'replyToCommentPHID' => $comment->getReplyToCommentPHID(),
'isDone' => $is_done,
); );
} }